Remove Equ usage #552
Open
Remove Equ usage #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkm
requested changes
Aug 21, 2024
IsIdentifiable/Failures/Failure.cs
Outdated
|
|
||
| /// <summary> | ||
| /// Description of the item being evaluated (e.g. table name, file name etc) | ||
| /// </summary> | ||
| public string Resource { get; set; } | ||
| public string? Resource { get; init; } |
There was a problem hiding this comment.
This seems unrelated to the Equ removal? Also, I don't think this (and others) should ever be null really.
There was a problem hiding this comment.
Have broken some bits out into #573, will refine and resubmit the Equ bits after that
Disallow null resource values in Failure.cs
…into feature/nequ
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
- Coverage 39.51% 39.37% -0.14%
==========================================
Files 68 68
Lines 3837 3843 +6
Branches 521 529 +8
==========================================
- Hits 1516 1513 -3
- Misses 2224 2226 +2
- Partials 97 104 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Equ - only one non-trivial usage, removes dependency and some unnecessary reflection internally.