Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold assoc #156

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Threshold assoc #156

merged 5 commits into from
Jul 20, 2021

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Jul 16, 2021

Relates to #155

@tznind tznind requested a review from jas88 July 16, 2021 16:10
Copy link
Member

@jas88 jas88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A LinkedList and removing .First would give O(1) time instead of O(n), but if you need this in ASAP we can file that for a later enhancement. (Maybe package it as a separate library too, I'm sure we could use throttling more widely.)

@tznind
Copy link
Contributor Author

tznind commented Jul 19, 2021

A LinkedList and removing .First would give O(1) time instead of O(n), but if you need this in ASAP we can file that for a later enhancement. (Maybe package it as a separate library too, I'm sure we could use throttling more widely.)

That makes sense except that the API doesn't assume DateTime events will arrive in order. I was thinking about this and realised it wasn't threadsafe so I have fixed that in e931177

@tznind tznind merged commit 96110f1 into develop Jul 20, 2021
@tznind tznind deleted the threshold-assoc branch July 20, 2021 13:53
@jas88
Copy link
Member

jas88 commented Jul 18, 2022

@tznind .Net 7 brings exciting new high efficiency rate-limiting mechanisms we might benefit from once it's officially out in November.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants