Merge pull request #785 from SMI/reviewer-fixes

Disabled tree rebuilding until loading is complete
SMI · Jun 11, 2021 · 88943fe · 88943fe
2 parents 7456aa2 + 10a2d5d
commit 88943fe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/news/785-bugfix.md b/news/785-bugfix.md
@@ -0,0 +1 @@
+Fixed bug with multiple enumeration during loading very large failure reports in IsIdentifiableReviewer
diff --git a/src/applications/Applications.IsIdentifiableReviewer/Views/RulesView.cs b/src/applications/Applications.IsIdentifiableReviewer/Views/RulesView.cs
@@ -330,7 +330,6 @@ private void EvaluateRuleCoverage()
 
             AddDuplicatesToTree(allRules);
 
-            _treeView.AddObjects(new []{ colliding,ignore,update,outstanding});
 
             var cts = new CancellationTokenSource();
 
@@ -354,21 +353,23 @@ private void EvaluateRuleCoverage()
 
             Application.MainLoop.AddTimeout(TimeSpan.FromSeconds(1), (s) =>
             {
-                _treeView.RebuildTree();
                 dlg.SetNeedsDisplay();
                 return !done;
             });
 
             Task.Run(()=>{
                 EvaluateRuleCoverageAsync(stage,progress,textProgress,cts.Token,colliding,ignore,update,outstanding);
-                },cts.Token).ContinueWith((t)=>{
+                },cts.Token).ContinueWith((t,s)=>{
                 
                     btn.Clicked -= cancelFunc;
                     btn.Text = "Done";
                     btn.Clicked += closeFunc;
                     done = true;
                     cts.Dispose();
-            });
+
+                    _treeView.RebuildTree();
+                    _treeView.AddObjects(new[] { colliding, ignore, update, outstanding });
+                },SynchronizationContext.Current);
 
             Application.Run(dlg);
         }