Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add packages lockfile #1875

Merged
merged 5 commits into from
Oct 11, 2024
Merged

add packages lockfile #1875

merged 5 commits into from
Oct 11, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Jul 23, 2024

Proposed Changes

Adds package restores using a lockfile.

This shouldn't be merged until Dependabot is aware of the lockfile format (dependabot/dependabot-core#1303 and dependabot/dependabot-core#9678)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

N/A.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.81%. Comparing base (83dc691) to head (525514c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1875   +/-   ##
=======================================
  Coverage   64.81%   64.81%           
=======================================
  Files         183      183           
  Lines        6554     6554           
  Branches      963      963           
=======================================
  Hits         4248     4248           
  Misses       2020     2020           
  Partials      286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm
Copy link
Member Author

rkm commented Oct 4, 2024

dependabot-core is now aware of lockfiles, however the GitHub app hasn't been updated yet. Tracking this in https://github.com/rkm/dependabot-nuget-lockfile-test

@rkm
Copy link
Member Author

rkm commented Oct 10, 2024

Looks like the dependabot bug has been fixed now, so this PR can proceed

@rkm rkm marked this pull request as ready for review October 11, 2024 10:47
@rkm rkm requested a review from a team October 11, 2024 10:47
@rkm rkm enabled auto-merge (rebase) October 11, 2024 10:47
@rkm rkm merged commit 70a4b26 into main Oct 11, 2024
19 checks passed
@rkm rkm deleted the lockfile branch October 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants