Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less Oracle, more cowb - er, Postgresql #1879

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Less Oracle, more cowb - er, Postgresql #1879

merged 2 commits into from
Aug 3, 2024

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Jul 25, 2024

Proposed Changes

Remove Oracle remnants, fill in some gaps in Postgresql support instead.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Partly addresses #1878

@jas88 jas88 requested a review from rkm July 25, 2024 21:48
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.38%. Comparing base (7c407ff) to head (e216930).
Report is 17 commits behind head on main.

Files Patch % Lines
...per/Execution/Swappers/ForGuidIdentifierSwapper.cs 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   60.96%   60.38%   -0.59%     
==========================================
  Files         177      177              
  Lines        6559     6548      -11     
  Branches      898      898              
==========================================
- Hits         3999     3954      -45     
- Misses       2289     2327      +38     
+ Partials      271      267       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm merged commit 9fe5c79 into main Aug 3, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants