Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

135 redefine filters #152

Open
wants to merge 13 commits into
base: devel
Choose a base branch
from
Open

135 redefine filters #152

wants to merge 13 commits into from

Conversation

Kim4213
Copy link
Contributor

@Kim4213 Kim4213 commented Apr 12, 2023

Added Andicam NIR and TJO filters

@Kim4213 Kim4213 requested a review from emirkmo April 12, 2023 14:41
Copy link
Member

@emirkmo emirkmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add an AndiCamIR instrument class. You can have it inherit from AndiCam, but have a different instrument header name and overwrite the get_photfilter method.

This won't work.

@@ -432,7 +432,13 @@ def get_obstime(self):
return obstime

def get_photfilter(self):
return self.image.header['CCDFLTID']
instrument = self.image.header['INSTRUME']
if instrument == 'ANDICAM-IR':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instrument is already set to be ANDICAM-CCD, so create a new AndiCamIR instrument for this. If the instrument field is AndiCamIR this class won't even detect that the image belongs to the AndiCam pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried something like:
class AndiCamIR(Instrument):
andicam = AndiCam()
siteid = andicam.siteid
instrument = 'ANDICAM-CCD’
unique_headers = andicam.unique_headers

def get_obstime(self):
    return andicam.get_obstime()

def get_photfilter(self):
    return self.image.header['IRFLTID']

However, this does not seem to work. In the current commit, I added some spaces to a file, but it seems it does not pass the checks. Is something off with the pipeline?

@Kim4213 Kim4213 requested a review from emirkmo April 14, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants