-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
135 redefine filters #152
base: devel
Are you sure you want to change the base?
135 redefine filters #152
Conversation
Adding IR-filters to ANDICAM and adding filters for TJO MEIA3
… into 135-redefine_filters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add an AndiCamIR instrument class. You can have it inherit from AndiCam, but have a different instrument header name and overwrite the get_photfilter
method.
This won't work.
flows/instruments/instruments.py
Outdated
@@ -432,7 +432,13 @@ def get_obstime(self): | |||
return obstime | |||
|
|||
def get_photfilter(self): | |||
return self.image.header['CCDFLTID'] | |||
instrument = self.image.header['INSTRUME'] | |||
if instrument == 'ANDICAM-IR': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instrument is already set to be ANDICAM-CCD, so create a new AndiCamIR instrument for this. If the instrument field is AndiCamIR this class won't even detect that the image belongs to the AndiCam pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried something like:
class AndiCamIR(Instrument):
andicam = AndiCam()
siteid = andicam.siteid
instrument = 'ANDICAM-CCD’
unique_headers = andicam.unique_headers
def get_obstime(self):
return andicam.get_obstime()
def get_photfilter(self):
return self.image.header['IRFLTID']
However, this does not seem to work. In the current commit, I added some spaces to a file, but it seems it does not pass the checks. Is something off with the pipeline?
Added Andicam NIR and TJO filters