Merge pull request #196 from SOBotics/hotfix/195-checkuser-threshold

Fix #195: Add dynamic threshold to checkuser command
SOBotics · Jul 12, 2019 · 78d4a9b · 78d4a9b
2 parents 405c0ca + 50b4268
commit 78d4a9b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/pom.xml b/pom.xml
@@ -22,7 +22,7 @@
 
 	<groupId>de.felixsfd.stackoverflow</groupId>
 	<artifactId>guttenberg</artifactId>
-	<version>1.2.4</version>
+    <version>1.2.5</version>
 
 	<dependencies>
 		<dependency>

diff --git a/src/main/java/org/sobotics/guttenberg/commands/CheckInternet.java b/src/main/java/org/sobotics/guttenberg/commands/CheckInternet.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019 SOBotics (https://sobotics.org) and contributors in GitHub
+ * Copyright (C) 2019 SOBotics (https://sobotics.org) and contributors on GitHub
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -86,6 +86,14 @@ public void execute(Room room, RunnerService instance) {
     }
 
     Properties prop = Guttenberg.getLoginProperties();
+    Properties generalProp = Guttenberg.getGeneralProperties();
+    double reportThreshold;
+    try {
+      reportThreshold = Double.parseDouble(generalProp.getProperty("checkuser_minimumScore", "0.80"));
+    } catch (NumberFormatException e) {
+      reportThreshold = 0.8;
+    }
+
     Post post = null;
 
     LOGGER.info("Executing command on user id: " + postId);
@@ -135,7 +143,7 @@ public void execute(Room room, RunnerService instance) {
       sendChatMessage(room, message);
 
       for (PostMatch postMatch : matches) {
-        if (postMatch.getTotalScore() > 0.75) {
+        if (postMatch.getTotalScore() > reportThreshold) {
           outputDirectHit(room, postMatch);
         }
       }

diff --git a/src/main/java/org/sobotics/guttenberg/commands/CheckUser.java b/src/main/java/org/sobotics/guttenberg/commands/CheckUser.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019 SOBotics (https://sobotics.org) and contributors in GitHub
+ * Copyright (C) 2019 SOBotics (https://sobotics.org) and contributors on GitHub
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -83,6 +83,14 @@ public void execute(Room room, RunnerService instance) {
       return;
     }
     Properties prop = Guttenberg.getLoginProperties();
+    Properties generalProp = Guttenberg.getGeneralProperties();
+    double reportThreshold;
+    try {
+      reportThreshold = Double.parseDouble(generalProp.getProperty("checkuser_minimumScore", "0.80"));
+    } catch (NumberFormatException e) {
+      reportThreshold = 0.8;
+    }
+
     LOGGER.info("Executing command on user id: " + userId);
 
     boolean log = cmd.contains("-log");
@@ -158,7 +166,7 @@ public void execute(Room room, RunnerService instance) {
           }
 
           for (PostMatch postMatch : matches) {
-            if (postMatch.getTotalScore() > 0.75) {
+            if (postMatch.getTotalScore() > reportThreshold) {
               outputDirectHit(room, postMatch);
             }
           }