Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change system parameters from traits to structs #52

Merged
merged 28 commits into from
Oct 21, 2023

Conversation

SOF3
Copy link
Owner

@SOF3 SOF3 commented Sep 30, 2023

also fixes #51

@SOF3
Copy link
Owner Author

SOF3 commented Oct 1, 2023

also fixes #51 since the Accessor trait has been rewritten and the Storage traits are no longer unsafe.

and update the accessors macro, renamed to zip
@SOF3 SOF3 marked this pull request as ready for review October 2, 2023 16:05
@SOF3
Copy link
Owner Author

SOF3 commented Oct 2, 2023

Some broken doc links still need fixing

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Attention: 169 lines in your changes are missing coverage. Please review.

Comparison is base (b3131e4) 65.51% compared to head (c4c08f2) 67.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   65.51%   67.70%   +2.18%     
==========================================
  Files          75       86      +11     
  Lines        5133     6314    +1181     
==========================================
+ Hits         3363     4275     +912     
- Misses       1770     2039     +269     
Files Coverage Δ
src/comp/any.rs 97.14% <ø> (ø)
src/comp/discrim.rs 95.50% <ø> (ø)
src/entity.rs 100.00% <100.00%> (ø)
src/entity/ealloc/snapshot.rs 77.27% <100.00%> (-22.73%) ⬇️
src/macros.rs 71.42% <100.00%> (-3.58%) ⬇️
src/storage.rs 100.00% <100.00%> (ø)
src/storage/tests.rs 100.00% <100.00%> (ø)
src/storage/tree.rs 100.00% <100.00%> (ø)
src/system.rs 0.00% <ø> (ø)
src/system/access/isotope.rs 100.00% <100.00%> (ø)
... and 39 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3
Copy link
Owner Author

SOF3 commented Oct 16, 2023

Still missing par_entities_with and par_chunks_with

@SOF3 SOF3 merged commit c4c08f2 into master Oct 21, 2023
8 checks passed
@SOF3 SOF3 deleted the accessor-struct branch November 6, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsafety of Storage is actually unsound
2 participants