Optimize VMFrame Creation #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smarr
commented
Aug 11, 2024
smarr
commented
- move most bits to the constructor
- do not initialize arguments with nil since they will be set during the call
Signed-off-by: Stefan Marr <[email protected]>
Though, need to make sure I initialize the bootstrap frame arguments. Otherwise, we may run into uninitialized memory. Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
optimize-frame-creation
branch
from
970f3c3 to
4ce1f21
Compare
|
Results a bit flaky, not sure: median 0% (min. -19%, max. 18%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.