Make VMFrame an AbstractVMObject and allow for more inlining #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <[email protected]>
By moving them to the headers. Signed-off-by: Stefan Marr <[email protected]>
It doesn’t need to be a VMObject, and ideally it wouldn’t be a AbstractVMObject either, but one step after another. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Move the error handling behind a method boundary and make the rest inlinable. Signed-off-by: Stefan Marr <[email protected]>
|
The main performance impact comes from making sure array accessors can be inlined: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractVMObject is simpler than VMObject, avoids some fields and other bits.
The rest is moving some bits to headers to allow the compilers to inline.