Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] 마이페이지 메인 코드 정리 #97

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

HAJIEUN02
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  • Spacer → 확장 함수로 빼둔 Gap으로 전부 수정
  • MVI Contract 네이밍 통일

Screenshot 📸

XRecorder_20250226_03.mp4

Uncompleted Tasks 😅

없더용

To Reviewers 📢

배지 도감 들어가면 앱이 터져잉~ㅜ.ㅜ
이 또한 해결되면 머지하리라
image

@HAJIEUN02 HAJIEUN02 added this to the 앱잼 코드 정리 milestone Feb 26, 2025
@HAJIEUN02 HAJIEUN02 self-assigned this Feb 26, 2025
@HAJIEUN02 HAJIEUN02 requested a review from a team as a code owner February 26, 2025 13:38
Copy link
Contributor

@beom84 beom84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM~!

Copy link
Contributor

@kamja0510 kamja0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨수다

onClickWithdrawConfirmBtn = { viewModel.setEvent(MyContract.MyEvent.OnClickWithdrawConfirmBtn) },
onClickLogoutCancelBtn = { viewModel.setEvent(MyContract.MyEvent.OnClickLogoutCancelBtn) },
onClickWithdrawCancelBtn = { viewModel.setEvent(MyContract.MyEvent.OnClickWithdrawCancelBtn) },
onClickBbangZip = { viewModel.setEvent(MyContract.MyEvent.OnBbangZipClick) },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3 : parameter 이벤트 네이밍이 안바껴있습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] 마이페이지 메인 코드 정리
3 participants