Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAB1] 312551148 #16

Merged
merged 7 commits into from
Mar 7, 2024
Merged

[LAB1] 312551148 #16

merged 7 commits into from
Mar 7, 2024

Conversation

ming-hsien
Copy link

@ming-hsien ming-hsien commented Feb 29, 2024

Description

#2

Add some testing function for lab1.


  • A clear title
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@ming-hsien ming-hsien changed the base branch from main to 312551148 February 29, 2024 08:18
@TaiYou-TW TaiYou-TW closed this Feb 29, 2024
@TaiYou-TW TaiYou-TW reopened this Feb 29, 2024
@TaiYou-TW TaiYou-TW added lab1 and removed lab1 labels Feb 29, 2024
@TaiYou-TW
Copy link
Contributor

TaiYou-TW commented Mar 7, 2024

@ming-hsien Sorry for not noticing your CI failed to run. But your unit testing has failed. You can fix them and will not receive a late submission penalty before today 23:59.

@TaiYou-TW TaiYou-TW merged commit 98036e8 into SQLab:312551148 Mar 7, 2024
2 checks passed
@TaiYou-TW
Copy link
Contributor

image
Please avoid leaving such test commits when you open a PR next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants