Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP-draft] Multi quarters API [do-NOT-merge] #53

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jorgemarpa
Copy link
Contributor

This PR shows how to adapt the API to work with multi-quarter TPFS of the same sky group, e.g. TPFs of Kepler quarter 1, 5, 9.
It includes a custom multi-quarter method (_parse_multi_quarter_TPFs) that uses masks to find shared TPF pixels between quarters, this is necessary because sometimes the target masks change between quarters. For now, we only used pixels that have data in all quarters, this can be improved in the future to keep pixels with missing quarters.

TODO:

  • The pixel masks used to concatenate TPF quarters can be replaced by Pandas DataFrames and the pd.merge method, this could be faster and cleaner.
  • Keep pixels with missing quarters. Using Pandas to merge TPFs could make this easier, but need to change the machine API to allow missing data.

Note:
This PR uses #52, which adds the "segment" method to the time model fitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants