Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mobile | Fix code unrecognised popup on first login on Android #1085

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

zacharykeeping
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Closes #1084

  1. What was changed?

It seems on Android the login callback triggers the OnAppLinkRequestReceived method that we're using to capture links using our custom URL scheme. This updates this method to check for the correct URL scheme and only execute if it matches our own.

  1. Did you do pair or mob programming?

No

Copy link
Contributor

@matt-goldman-ssw matt-goldman-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zacharykeeping zacharykeeping merged commit 592386e into main Oct 15, 2024
6 checks passed
@zacharykeeping zacharykeeping deleted the code-fix branch October 15, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Mobile | Code unrecognised error on first login on Android
2 participants