Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ ♻️ Fixed image extensions and names 3 #9179

Merged
merged 10 commits into from
Sep 15, 2024
Merged

XS✔ ◾ ♻️ Fixed image extensions and names 3 #9179

merged 10 commits into from
Sep 15, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Sep 14, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ SSWConsulting/SSW.Rules#1431

  1. What was changed?

✏️ Changed the image extension to lowercase

  1. Did you do pair or mob programming (list names)?

✏️ No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Sep 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 14, 2024 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 18
Total 18

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title ♻️ Fixed image extensions and names 3 XS✔ ◾ ♻️ Fixed image extensions and names 3 Sep 14, 2024
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Sep 14, 2024
@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Sep 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Howzit @babakamyljanovssw,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@bradystroud bradystroud merged commit f997546 into main Sep 15, 2024
5 checks passed
@bradystroud bradystroud deleted the fix-images-3 branch September 15, 2024 22:06
@babakamyljanovssw babakamyljanovssw mentioned this pull request Sep 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradystroud bradystroud bradystroud approved these changes

@tiagov8 tiagov8 tiagov8 approved these changes

Assignees
No one assigned
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babakamyljanovssw @tiagov8 @bradystroud