Merge #6306

6306: The hpxcxx script was broken such that it could only compile for _release r=hkaiser a=stevenrbrandt

The hpxcxx script was broken such that it could only compile for _release. This modification makes it more robust in finding a compiled hpx installation and changes the 2 character flags to use -- instead of -.

Fixes #

## Proposed Changes

  - Changes 2 character flags so that they use -- instead of -
  - Fixes bug which prevents non-release versions from working
  - Makes specifying the release optional
  -  corrects relwithdebinfo to relwithdebuginfo

## Any background context you want to provide?

## Checklist

Not all points below apply to all pull requests.

- [ ] I have added a new feature and have added tests to go along with it.
- [ ] I have fixed a bug and have added a regression test.
- [ ] I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.


Co-authored-by: Steven R. Brandt <[email protected]>

cmake/templates/hpxcxx.in

@@ -39,8 +39,8 @@ pkgconfpath += [
     os.path.join("@HPX_CONF_PREFIX@","lib64","pkgconfig"),     # install directory
     os.path.join(os.path.dirname(sys.argv[0]),"..","lib","pkgconfig"),
     os.path.join("opt","hpx","lib","pkgconfig"),
-    os.path.join("usr","bin","hpx","lib","pkgconfig"),
-    os.path.join("usr","local","bin","hpx","lib","pkgconfig"),
+    os.path.join("/usr","bin","hpx","lib","pkgconfig"),
+    os.path.join("/usr","local","bin","hpx","lib","pkgconfig"),
     os.path.join(os.environ["HOME"],"install","hpx","lib","pkgconfig"),
     os.path.join(os.environ["HOME"],"hpx","lib","pkgconfig")
     ]
@@ -54,14 +54,14 @@ Usage: hpxcxx -c flags files
 The hpxcxx command requires that you build either
 a component, an application, or that you specify
 the -c flag. If you are building against a debug
-build, you need to specify -g.
-If release-with-debug-info, specify -rd
-If minsize-release specify -mr. All other flags
+build, you need to specify --db.
+If release-with-debug-info, specify --rd
+If minsize-release specify --mr. All other flags
 are passed through to the underlying C++ compiler.
 """)
     sys.exit(2)
 
-pkgconf_suffix = ['_release', '_relwithdebuginfo', '_debug', '_minsizerel']
+pkgconf_suffix = '_release'
 i = 1
 while i < len(sys.argv):
 
@@ -76,6 +76,7 @@ while i < len(sys.argv):
     elif sys.argv[i].startswith('--exe='):
         output=sys.argv[i][6:]
         app = output
+        #args += ['-o',app+'.exe']
         application = True
     elif sys.argv[i].startswith('--comp='):
         app_name = sys.argv[i][7:]
@@ -93,28 +94,24 @@ while i < len(sys.argv):
     elif sys.argv[i] == '-c':
         minusc = True
         pass
-    elif sys.argv[i].startswith('-g'):
-        pkgconf_suffix = ['_debug']
-        args += [sys.argv[i]]
-    elif sys.argv[i] == '--rd':
-        pkgconf_suffix = ['_relwithdebuginfo']
-    elif sys.argv[i] == '--mr':
-        pkgconf_suffix = ['_minsizerel']
-    elif sys.argv[i] == '-r':
-        pkgconf_suffix = ['_release']
+    elif sys.argv[i].startswith('-db'):
+        pkgconf_suffix = '_debug'
+    elif sys.argv[i].startswith('--rd'):
+        pkgconf_suffix = '_relwithdebuginfo'
+    elif sys.argv[i].startswith('--mr'):
+        pkgconf_suffix = '_minsizerel'
     else:
         args += [sys.argv[i]]
 
     i += 1
 
 pkgconf = None
 for path in pkgconfpath:
-    if pkgconf is not None:
-        break
-    for suffix in pkgconf_suffix:
+    for suffix in [pkgconf_suffix, "_release", "_relwithdebuginfo","_debug","_minsizerel"]:
         hpath = os.path.join(path,"hpx_application")+suffix+".pc"
         if os.path.exists(hpath):
             pkgconf = path
+            pkgconf_suffix = suffix
             break
 
 if pkgconf == None:
@@ -128,11 +125,11 @@ else:
     os.environ[pkg] = pkgconf
 
 if application:
-    args += ["`pkg-config --cflags --libs hpx_application" + suffix + "`"]
+    args += ["`pkg-config --cflags --libs hpx_application" + pkgconf_suffix + "`"]
 elif component:
-    args += ["`pkg-config --cflags --libs hpx_component" + suffix + "`"]
+    args += ["`pkg-config --cflags --libs hpx_component" + pkgconf_suffix + "`"]
 else:
-    args += ["`pkg-config --cflags hpx_application" + suffix + "`"]
+    args += ["`pkg-config --cflags hpx_application" + pkgconf_suffix + "`"]
 
 if not component and not application and not minusc:
     usage()