Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure changed number of cores is propagated to executor #6309

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jul 25, 2023

No description provided.

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each-??-

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002023-07-26T16:01:37+00:00
HPX Commitdcb541592882e8
Envfile
Clusternamerostamrostam
Datetime2023-05-10T14:50:18.616050-05:002023-07-26T12:23:36.914398-05:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002023-07-26T16:01:37+00:00
HPX Commitdcb541592882e8
Envfile
Clusternamerostamrostam
Datetime2023-05-10T14:52:35.047119-05:002023-07-26T12:25:55.233587-05:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)=(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)=(=)

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002023-07-26T16:01:37+00:00
HPX Commitdcb541592882e8
Envfile
Clusternamerostamrostam
Datetime2023-05-10T14:52:52.237641-05:002023-07-26T12:26:13.988864-05:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser hkaiser changed the title Making sure changed number of counts is propagated to executor Making sure changed number of cores is propagated to executor Jul 27, 2023
@hkaiser hkaiser force-pushed the fixing_num_cores branch 4 times, most recently from eb43bbc to 84c9517 Compare August 1, 2023 22:12
@hkaiser hkaiser force-pushed the fixing_num_cores branch 6 times, most recently from 2919a3b to 58e0fc3 Compare August 5, 2023 16:14
@Pansysk75
Copy link
Member

@hkaiser I can barely reproduce the failing tests, and attaching gdb stops the failures. We will have to get really creative for this one

@hkaiser
Copy link
Member Author

hkaiser commented Aug 20, 2023

bors merge

@bors
Copy link

bors bot commented Aug 20, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 38d5bf9 into master Aug 20, 2023
18 checks passed
@bors bors bot deleted the fixing_num_cores branch August 20, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants