Relocation algorithms Clean #6314

isidorostsa · 2023-07-28T20:04:58Z

This is a reiteration of isidorostsa#2 which unfortunately got tangled up due to some mishandling of versioning on my end. Feedback from the original PR, specifically Arthur's comments, has been considered and implemented in this iteration.

Also, tests that are expected to fail to compile have been implemented.

The original pr's description:

This is a starting point for the implementation of the P1144 relocate_at and uninitialized_relocate algorithms for HPX. They will later be used as base primitives for parallelized versions.

StellarBot · 2023-07-28T20:05:04Z

Can one of the admins verify this patch?

hkaiser · 2023-07-28T20:24:58Z

add to whitelist

hkaiser

We do have a facility that decides whether copy/move should use memcpy/memmove. Not sure if that's of use for you in this context (see: https://github.com/STEllAR-GROUP/hpx/blob/master/libs/core/algorithms/include/hpx/parallel/util/transfer.hpp).

libs/core/type_support/include/hpx/type_support/uninitialized_relocate.hpp

libs/core/type_support/tests/unit/relocate_at.cpp

libs/core/type_support/include/hpx/type_support/uninitialized_relocate.hpp

isidorostsa · 2023-07-28T21:59:12Z

We do have a facility that decides whether copy/move should use memcpy/memmove. Not sure if that's of use for you in this context (see: https://github.com/STEllAR-GROUP/hpx/blob/master/libs/core/algorithms/include/hpx/parallel/util/transfer.hpp).

Thanks for reviewing. I think the end goal is indeed to integrate relocation into transfer. In this PR I'm laying the groundwork by incorporating as many HPX facilities as possible into the conventional version.

libs/core/type_support/tests/unit/uninitialized_relocate.cpp

gonidelis · 2023-08-01T02:23:06Z

@Pansysk75 Is jenkins/lsu failing a known issue? I know that boost has not been "loadable" on Rostam for a while now and we rather have to access it directly from /usr/lib (or /opt cannot recollect exactly)?

Lmod has detected the following error: These module(s) or extension(s) exist
but cannot be loaded as requested: "boost"
   Try: "module spider boost" to see how to load the module(s).

hkaiser · 2023-08-01T11:35:04Z

Is jenkins/lsu failing a known issue? I know that boost has not been "loadable" on Rostam for a while now and we rather have to access it directly from /usr/lib (or /opt cannot recollect exactly)?

jenkins/lsu is failing if one of the LSU builders fails. The hipcc failures are a know issue (@G-071 is working on it). However the isuees reported by inspect is genuine.

isidorostsa · 2023-08-01T12:00:41Z

However the isuees reported by inspect is genuine.

I am not sure how I should interpret inspect failing, can I look beyond https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/15462/workflows/452015fb-b56b-48c3-a18d-1eccf5e2c72f/jobs/357090 ?

Pansysk75 · 2023-08-01T12:03:28Z

However the isuees reported by inspect is genuine.

I am not sure how I should interpret inspect failing, can I look beyond https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/15462/workflows/452015fb-b56b-48c3-a18d-1eccf5e2c72f/jobs/357090 ?

@isidorostsa You can to the Artifacts tab and download the html report file

@gonidelis

Lmod has detected the following error: These module(s) or extension(s) exist
but cannot be loaded as requested: "boost"
   Try: "module spider boost" to see how to load the module(s).

FYI boost can be loaded on Rostam, you just have to load a compiler first (that's how it behaves for me at least, check out module spider boost).

isidorostsa · 2023-08-01T12:06:32Z

Ohh thanks, looks like a line was too many characters. I may have found the culprit...

        hpx::relocate_at(ptr1, ptr2);

        // count = 1 + 0 (relocation on trivially relocatable objects does not trigger move constructors
        // or destructors); no object is destroyed or created
        HPX_TEST(trivially_relocatable_struct::count == 1);

…x_fork into relocate_algorithms_clean

StellarBot · 2023-08-23T18:24:11Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	??	(=)

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-23T18:13:20+00:00
HPX Commit	`dcb5415`	`95a70a0`
Clustername	rostam	rostam
Datetime	2023-05-10T14:50:18.616050-05:00	2023-08-23T13:21:15.098880-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	=

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-23T18:13:20+00:00
HPX Commit	`dcb5415`	`95a70a0`
Clustername	rostam	rostam
Datetime	2023-05-10T14:52:35.047119-05:00	2023-08-23T13:23:29.622921-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	=
Stream Benchmark - Scale	(=)	(=)	=
Stream Benchmark - Triad	=	=	(=)
Stream Benchmark - Copy	=	-	(=)

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-23T18:13:20+00:00
HPX Commit	`dcb5415`	`95a70a0`
Clustername	rostam	rostam
Datetime	2023-05-10T14:52:52.237641-05:00	2023-08-23T13:23:47.000915-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

libs/core/algorithms/include/hpx/parallel/algorithms/uninitialized_relocate.hpp

isidorostsa · 2023-09-09T17:23:06Z

Closed in favor of #6344

6344: uninitialized_relocate w/ type_support primitive r=hkaiser a=isidorostsa This PR replaces the `type_support::uninitialized_relocate` with a primitive version for uninitialized relocation, named `uninitialized_relocate_n_primitive`. This is used by the parallel and sequenced versions of `algorithms::uninitialized_relocate`. In contrast to the previous attempt of implementing the relocation functions, #6314, this does not place the primitive in `transfer.hpp`, which is in the `algorithms` module, nor does it modify `loop.hpp` to add the specific exception handling method required by `uninitialized_relocate`. The goal of keeping a primitive in type support, which is relatively low level in terms of dependencies, is to use it in the higher level `small_vector` and other data structures. 6348: Adding --exclusive to launching tests on rostam r=hkaiser a=hkaiser 6349: Moving hpx::threads::run_as_xxx to namespace hpx r=hkaiser a=hkaiser - run_as_os_thread - run_as_hpx_thread Co-authored-by: isidorostsa <[email protected]> Co-authored-by: Hartmut Kaiser <[email protected]>

isidorostsa added 4 commits July 27, 2023 11:01

relocate_at impl w/ tests

2709dd9

uninitialized_relocate w/ tests and comments fixed

3afc851

expected compile error tests

0b3a6e8

clang-format

fe6e0fb

isidorostsa requested review from aurianer, msimberg, biddisco and hkaiser as code owners July 28, 2023 20:04

hkaiser added type: enhancement type: compatibility issue category: algorithms labels Jul 28, 2023

hkaiser added this to the 1.10.0 milestone Jul 28, 2023

hkaiser requested changes Jul 28, 2023

View reviewed changes

hkaiser reviewed Jul 28, 2023

View reviewed changes

libs/core/type_support/include/hpx/type_support/uninitialized_relocate.hpp Outdated Show resolved Hide resolved

isidorostsa added 2 commits July 29, 2023 17:27

add explicit-noexcept where it is missing

8ef523a

enum instead of magic numbers

13a1279

hkaiser reviewed Jul 29, 2023

View reviewed changes

libs/core/type_support/tests/unit/uninitialized_relocate.cpp Outdated Show resolved Hide resolved

isidorostsa added 4 commits July 30, 2023 18:04

remove explicit from move constructors

2c9edb0

add explicit to relocate_at.cpp too

36b70cb

fix Werror=class-memaccess, cast away const

148d729

clang-format

cafae0c

isidorostsa requested a review from hkaiser July 31, 2023 15:05

isidorostsa added 16 commits August 22, 2023 14:08

change uninitialzied_relocate_n test name

db65f32

uninitialized_relocate iterators version

8f0cc63

add noexcept relocation detector

6e1e85e

use HPX_CONCEPT_REQUIRES, detect noexcepts

db8ed7c

fix returned value of nothrow relocation

a3d51bf

clang-format

00fb2e5

clang-format

0d3d917

inspect

0d3a178

Merge branch 'relocate_algorithms_clean' of github.com:isidorostsa/hp…

0a60cf8

…x_fork into relocate_algorithms_clean

remove unneeded params + clang-format

1a2e8a7

using execution_policy instead of hpx/execution

99c4dbb

include fixes

36080a3

remove unused var

a9f9e9a

unwrap zip_iterator manually

32ed3c1

clang-format

c288589

gcc11 fix unpacking iterators

95a70a0

isidorostsa added 3 commits August 24, 2023 09:18

clang-format

4b98351

Add doxygen docs

909998c

clang-format

4bdc115

dimitraka reviewed Aug 24, 2023

View reviewed changes

libs/core/algorithms/include/hpx/parallel/algorithms/uninitialized_relocate.hpp Show resolved Hide resolved

dimitraka reviewed Aug 24, 2023

View reviewed changes

libs/core/algorithms/include/hpx/parallel/algorithms/uninitialized_relocate.hpp Show resolved Hide resolved

isidorostsa added 4 commits August 24, 2023 13:40

docs typo

1e57fe5

EOF endline

426c52a

public api gives better warnings

8fd47df

atomics in test

d26c2f6

isidorostsa closed this Sep 9, 2023

isidorostsa mentioned this pull request Sep 9, 2023

uninitialized_relocate w/ type_support primitive #6344

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relocation algorithms Clean #6314

Relocation algorithms Clean #6314

isidorostsa commented Jul 28, 2023

StellarBot commented Jul 28, 2023

hkaiser commented Jul 28, 2023

hkaiser left a comment

isidorostsa commented Jul 28, 2023

gonidelis commented Aug 1, 2023

hkaiser commented Aug 1, 2023

isidorostsa commented Aug 1, 2023 •

edited

Loading

Pansysk75 commented Aug 1, 2023 •

edited

Loading

isidorostsa commented Aug 1, 2023 •

edited

Loading

StellarBot commented Aug 23, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

isidorostsa commented Sep 9, 2023

Relocation algorithms Clean #6314

Relocation algorithms Clean #6314

Conversation

isidorostsa commented Jul 28, 2023

The original pr's description:

StellarBot commented Jul 28, 2023

hkaiser commented Jul 28, 2023

hkaiser left a comment

Choose a reason for hiding this comment

isidorostsa commented Jul 28, 2023

gonidelis commented Aug 1, 2023

hkaiser commented Aug 1, 2023

isidorostsa commented Aug 1, 2023 • edited Loading

Pansysk75 commented Aug 1, 2023 • edited Loading

isidorostsa commented Aug 1, 2023 • edited Loading

StellarBot commented Aug 23, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

isidorostsa commented Sep 9, 2023

isidorostsa commented Aug 1, 2023 •

edited

Loading

Pansysk75 commented Aug 1, 2023 •

edited

Loading

isidorostsa commented Aug 1, 2023 •

edited

Loading