Fix CMake conditionals checking ENV variables

[Pansysk75]

Fixes CMake conditional checks that depend on environment variables, since if(ENV{some_var}) would always evaluate to false:
https://cmake.org/cmake/help/latest/command/if.html#variable

[hkaiser]

Excellent catch!
LGTM, thanks!

[Pansysk75]

retest lsu

[StellarBot]

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-10-08T13:42:47+00:00
HPX Commit	d27ac2e	de993ef
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Datetime	2024-03-18T09:18:04.949759-05:00	2024-10-08T08:50:33.933261-05:00
Envfile
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-10-08T13:42:47+00:00
HPX Commit	d27ac2e	de993ef
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Datetime	2024-03-18T09:19:53.062988-05:00	2024-10-08T08:52:24.321395-05:00
Envfile
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-10-08T13:42:47+00:00
HPX Commit	d27ac2e	de993ef
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Datetime	2024-03-18T09:20:13.002391-05:00	2024-10-08T08:52:45.022564-05:00
Envfile
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 544cb851	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (544cb85)	Report Missing	Report Missing	Report Missing
Head commit (8c75983)	190931	162426	85.07%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6549)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩