Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lci pp: fix messages larger than INT_MAX #6566

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

lci pp: fix messages larger than INT_MAX #6566

wants to merge 4 commits into from
+238 −38

Conversation

JiakunYan
Copy link
Contributor

@JiakunYan JiakunYan commented Nov 8, 2024 •
edited
Loading

Thank @m-diers for reporting the bug. Test program provided by @m-diers

The LCI parcelport did not properly support messages larger than INT_MAX. This PR fixes the HPX side problem. The LCI side problem will be fixed by uiuc-hpc/lci#75 . I will update the default LCI autofetch tag soon.

This PR also adds a test for large messages. @hkaiser, let me know if I put the test program in the right directory.

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-08T05:31:18+00:00
HPX Commitd27ac2e48a34d9
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Datetime2024-03-18T09:18:04.949759-05:002024-11-07T23:40:12.533744-06:00
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-08T05:31:18+00:00
HPX Commitd27ac2e48a34d9
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Datetime2024-03-18T09:19:53.062988-05:002024-11-07T23:42:03.454929-06:00
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale-------
Stream Benchmark - Triad------
Stream Benchmark - Copy-------

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-08T05:31:18+00:00
HPX Commitd27ac2e48a34d9
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Datetime2024-03-18T09:20:13.002391-05:002024-11-07T23:42:23.884893-06:00
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@m-diers
Copy link
Contributor

m-diers commented Nov 8, 2024

For your information: The same problem exists with the MPI parcel port.

@JiakunYan
Copy link
Contributor Author

For your information: The same problem exists with the MPI parcel port.

Yeah. I will work on the MPI parcelport later.

@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.47% ✅ 80.77%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (342d373) 234436 200546 85.54%
Head commit (83686d0) 191442 (-42994) 162863 (-37683) 85.07% (-0.47%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6566) 78 63 80.77%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@hkaiser
Copy link
Member

hkaiser commented Nov 8, 2024

For your information: The same problem exists with the MPI parcel port.

It will most likely exist in all parcelports...

@hkaiser hkaiser added this to the 1.11.0 milestone Nov 8, 2024
@hkaiser
Copy link
Member

hkaiser commented Nov 8, 2024

This PR also adds a test for large messages. @hkaiser, let me know if I put the test program in the right directory.

Since this problem most likely exists in all parcelports, would you mind moving the test to the parcelset module (https://github.com/STEllAR-GROUP/hpx/tree/master/libs/full/parcelset/tests/regressions)?

@JiakunYan
Copy link
Contributor Author

JiakunYan commented Nov 8, 2024 •
edited
Loading

@hkaiser I don't think the ARGS argument of add_hpx_regression_test has any effects?

For example, this test tests.regressions.util.distributed.lci.zero_copy_parcels_1001_no_zero_copy_optimization

The cmake configuration is

  add_hpx_regression_test(
    "util" zero_copy_parcels_1001_no_zero_copy_optimization
    EXECUTABLE zero_copy_parcels_1001
    PSEUDO_DEPS_NAME zero_copy_parcels_1001 ${zero_copy_parcels_1001_PARAMETERS}
    ARGS --hpx:ini=hpx.parcel.zero_copy_optimization=0
  )

But the command line is still

/usr/bin/python3.9 "/work/jenkins/workspace/HPX/hpx/build/gcc-12-debug/bin/hpxrun.py" "/work/jenkins/workspace/HPX/hpx/build/gcc-12-debug/bin/zero_copy_parcels_1001_test" "-e" "0" "-t" "1" "-l" "2" "-p" "lci" "-r" "mpi" "-v" "--" "PSEUDO_DEPS_NAME" "zero_copy_parcels_1001" "--hpx:ini=hpx.parcel.mpi.ack_handshake!=1"

The same happens for my big_parcel_int_max_plus_1 test and that's why the MPI parcelport passed the test.

@hkaiser
Copy link
Member

hkaiser commented Nov 8, 2024

add_hpx_regression_test(
"util" zero_copy_parcels_1001_no_zero_copy_optimization
EXECUTABLE zero_copy_parcels_1001
PSEUDO_DEPS_NAME zero_copy_parcels_1001 ${zero_copy_parcels_1001_PARAMETERS}
ARGS --hpx:ini=hpx.parcel.zero_copy_optimization=0
)

Any additional (unparsed) argument passed to add_hpx_regression_test should end up being added to the command line of a test. I.e.

 add_hpx_regression_test(
    "util" zero_copy_parcels_1001_no_zero_copy_optimization
    EXECUTABLE zero_copy_parcels_1001
    PSEUDO_DEPS_NAME zero_copy_parcels_1001 ${zero_copy_parcels_1001_PARAMETERS}
    --hpx:ini=hpx.parcel.zero_copy_optimization=0
  )

should do the trick.

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Commitd27ac2e7d9829e
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T00:36:01+00:00
Envfile
Datetime2024-03-18T09:18:04.949759-05:002024-11-09T18:45:13.433264-06:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Commitd27ac2e7d9829e
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T00:36:01+00:00
Envfile
Datetime2024-03-18T09:19:53.062988-05:002024-11-09T18:47:03.411026-06:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale-------
Stream Benchmark - Triad------
Stream Benchmark - Copy-------

Info

PropertyBeforeAfter
HPX Commitd27ac2e7d9829e
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T00:36:01+00:00
Envfile
Datetime2024-03-18T09:20:13.002391-05:002024-11-09T18:47:23.761508-06:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@JiakunYan JiakunYan force-pushed the fix-bigmsg branch 2 times, most recently from 25d15b6 to a4b1932 Compare November 10, 2024 04:10
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Commitd27ac2e31af988
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T04:13:47+00:00
Clusternamerostamrostam
Datetime2024-03-18T09:18:04.949759-05:002024-11-09T22:20:09.618092-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Commitd27ac2e31af988
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T04:13:47+00:00
Clusternamerostamrostam
Datetime2024-03-18T09:19:53.062988-05:002024-11-09T22:22:01.240836-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale-------
Stream Benchmark - Triad------
Stream Benchmark - Copy-------

Info

PropertyBeforeAfter
HPX Commitd27ac2e31af988
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T04:13:47+00:00
Clusternamerostamrostam
Datetime2024-03-18T09:20:13.002391-05:002024-11-09T22:22:22.287788-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@codacy-production Codacy Production
Copy link

codacy-production bot commented Nov 10, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.41% ✅ 86.11%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5356c52) 234528 200611 85.54%
Head commit (a312910) 191533 (-42995) 163047 (-37564) 85.13% (-0.41%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6566) 108 93 86.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T17:12:29+00:00
HPX Commitd27ac2e160bedc
Datetime2024-03-18T09:18:04.949759-05:002024-11-10T11:19:59.617213-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clusternamerostamrostam

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T17:12:29+00:00
HPX Commitd27ac2e160bedc
Datetime2024-03-18T09:19:53.062988-05:002024-11-10T11:21:49.422544-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clusternamerostamrostam

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale------
Stream Benchmark - Triad------
Stream Benchmark - Copy------

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T17:12:29+00:00
HPX Commitd27ac2e160bedc
Datetime2024-03-18T09:20:13.002391-05:002024-11-10T11:22:10.013304-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clusternamerostamrostam

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Commitd27ac2e9ed8d5c
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T21:19:43+00:00
Datetime2024-03-18T09:18:04.949759-05:002024-11-10T15:24:58.579561-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Commitd27ac2e9ed8d5c
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T21:19:43+00:00
Datetime2024-03-18T09:19:53.062988-05:002024-11-10T15:26:48.365468-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale-------
Stream Benchmark - Triad------
Stream Benchmark - Copy------

Info

PropertyBeforeAfter
HPX Commitd27ac2e9ed8d5c
HPX Datetime2024-03-18T14:00:30+00:002024-11-10T21:19:43+00:00
Datetime2024-03-18T09:20:13.002391-05:002024-11-10T15:27:08.803513-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Commitd27ac2ed3f6164
HPX Datetime2024-03-18T14:00:30+00:002024-11-11T16:49:38+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime2024-03-18T09:18:04.949759-05:002024-11-11T10:55:13.155092-06:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Commitd27ac2ed3f6164
HPX Datetime2024-03-18T14:00:30+00:002024-11-11T16:49:38+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime2024-03-18T09:19:53.062988-05:002024-11-11T10:57:04.425068-06:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale------
Stream Benchmark - Triad------
Stream Benchmark - Copy-------

Info

PropertyBeforeAfter
HPX Commitd27ac2ed3f6164
HPX Datetime2024-03-18T14:00:30+00:002024-11-11T16:49:38+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime2024-03-18T09:20:13.002391-05:002024-11-11T10:57:24.819328-06:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-11T20:40:35+00:00
HPX Commitd27ac2e524da53
Clusternamerostamrostam
Envfile
Datetime2024-03-18T09:18:04.949759-05:002024-11-11T14:50:09.185939-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-11T20:40:35+00:00
HPX Commitd27ac2e524da53
Clusternamerostamrostam
Envfile
Datetime2024-03-18T09:19:53.062988-05:002024-11-11T14:51:58.986229-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale------
Stream Benchmark - Triad------
Stream Benchmark - Copy-------

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-11-11T20:40:35+00:00
HPX Commitd27ac2e524da53
Clusternamerostamrostam
Envfile
Datetime2024-03-18T09:20:13.002391-05:002024-11-11T14:52:19.738882-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@m-diers
Copy link
Contributor

m-diers commented Nov 13, 2024

@JiakunYan PP LCI now works here with the appropriate changes 👍

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Commitd27ac2ee28526a
HPX Datetime2024-03-18T14:00:30+00:002024-11-14T04:02:30+00:00
Datetime2024-03-18T09:18:04.949759-05:002024-11-13T22:10:08.768979-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Commitd27ac2ee28526a
HPX Datetime2024-03-18T14:00:30+00:002024-11-14T04:02:30+00:00
Datetime2024-03-18T09:19:53.062988-05:002024-11-13T22:12:00.164081-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale-----
Stream Benchmark - Triad------
Stream Benchmark - Copy-----

Info

PropertyBeforeAfter
HPX Commitd27ac2ee28526a
HPX Datetime2024-03-18T14:00:30+00:002024-11-14T04:02:30+00:00
Datetime2024-03-18T09:20:13.002391-05:002024-11-13T22:12:20.692700-06:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@JiakunYan
Copy link
Contributor Author

JiakunYan commented Nov 14, 2024 •
edited
Loading

@hkaiser The new test failed clang-16-debug mystically but worked fine for all other configurations. Do you have an instinct why?

From the test log, it seems the data transfer has been completed but the program was stuck in the finalization.

Update: I failed to reproduce this issue on Rostam with my own build.

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Commitd27ac2eadf6af8
HPX Datetime2024-03-18T14:00:30+00:002024-11-15T05:12:24+00:00
Datetime2024-03-18T09:18:04.949759-05:002024-11-14T23:20:09.270591-06:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Commitd27ac2eadf6af8
HPX Datetime2024-03-18T14:00:30+00:002024-11-15T05:12:24+00:00
Datetime2024-03-18T09:19:53.062988-05:002024-11-14T23:21:59.107682-06:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale------
Stream Benchmark - Triad------
Stream Benchmark - Copy------

Info

PropertyBeforeAfter
HPX Commitd27ac2eadf6af8
HPX Datetime2024-03-18T14:00:30+00:002024-11-15T05:12:24+00:00
Datetime2024-03-18T09:20:13.002391-05:002024-11-14T23:22:19.593509-06:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.41% ✅ 86.11%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5356c52) 234528 200611 85.54%
Head commit (aca1bbc) 191533 (-42995) 163047 (-37564) 85.13% (-0.41%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6566) 108 93 86.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser Awaiting requested review from hkaiser hkaiser is a code owner

Assignees
No one assigned
Labels
category: parcel transport type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JiakunYan @StellarBot @m-diers @hkaiser