Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add decep extension #265

Closed
wants to merge 1 commit into from
Closed

add decep extension #265

wants to merge 1 commit into from

Conversation

benjaminxscott
Copy link
Contributor

@bworrell - does this look good?

@gtback
Copy link
Contributor

gtback commented Jun 3, 2015

Empty commit? I'm confused. I'm guessing this is still a work in progress?

@benjaminxscott
Copy link
Contributor Author

@gtback
Copy link
Contributor

gtback commented Jun 11, 2015

deception isn't an extension point. Would it make sense for this to go somewhere else? We don't really have a place for "custom vocabs", since they are, by definition, custom.

@johnwunder
Copy link
Member

IMO this shouldn't be integrated into python-stix until the community discusses it and it gets added to STIX (as a built-in vocab).

@bworrell
Copy link
Contributor

@gtback, the extension part comes from the schemas PR that @bschmoker made. I agree with @johnwunder; we should wait until it makes its way into a release before merging it into the codebase.

@gtback
Copy link
Contributor

gtback commented Jun 12, 2015

In that case, any objections to closing the PR but leaving the branch?

@benjaminxscott
Copy link
Contributor Author

@gtback - would lean towards keeping open, since it'll act as a reminder
(and a stale branch will fall into obscurity)

@gtback
Copy link
Contributor

gtback commented Jul 15, 2016

Closing in the interest of cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants