Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ADC register defines #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jernejp21
Copy link

ADC registers were missing or had wrong bit field names according to reference manual. Added missing registers and fixed bit fields.

I would also like to point out errors in reference manual:

  • Between ADC_JDR4 and ADC_AWD2CR is reserved space. Offset address is wrong - 0x8C - 0x9C; correct is 0x90 - 0x9C.
    image
  • Last four registers have offset value: 0x3F0, 0x3F4, 0x3F8, 0x3FC. In the title it says that offset is already 0x300. This would imply that the correct offset is 0x6F0, 0x6F4, 0x6F8, 0x6FC. But this is wrong. Offset values should be 0xF0, 0xF4, 0xF8, 0xFC and reserved space should be in between (0x12 - 0xEC).
    image

ADC registers were missing or had wrong bit field names according to reference manual. Added missing registers and fixed bit fields.
@BernardPuel
Copy link
Contributor

Thanks for your contribution, I have entered 2 internal tickets for the CMSIS update + Documentation.

@BernardPuel
Copy link
Contributor

Documentation was updated and is under internal publication process. But the update will not be public soon ...
Thanks again.

Some register names have changed. Applied changes also to HAL files, not just header files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants