Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stm32duino changes #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Dec 15, 2022

  1. Fix comments in LoRaMacCallback_t

    It seems the comment for GetDevAddress was copied from GetUniqueId, but
    not changend sufficiently to be correct.
    matthijskooijman committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8372970 View commit details
    Browse the repository at this point in the history
  2. Fix printf format warnings

    These warnings are caused because frequencies are stored as `uint32_t`,
    which is `unsigned long`, while the printf format expects `int`. In
    practice, this does not actually cause problems, since on STM32 gcc
    `long` and `int` are both 32-bits and frequencies are never large enough
    to cause signed vs unsigned ambiguity.
    
    Since printf has no format specifiers for e.g. uint32_t (libc does have
    some macros for this, but those really hurt readability), this is tricky
    to fix in a portable way (other architectures or compilers might have
    `uint32_t` equal to `unsigned int` instead of `unsigned long`), this fix
    just casts the frequency to `unsigned` before passing it to printf (and
    for good measure, also convert the specifier from `%d` to `%u`). This
    does mean this printing will break if `int` is not at least 32-bits
    (e.g. on AVR), but given the scope of this library, that should be
    acceptable.
    matthijskooijman committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1c17e31 View commit details
    Browse the repository at this point in the history
  3. Add additional debug output

    This adds some more details about RX and TX bytes and TX config. There
    is also some code for RX config, but to minimize the impact on RX
    timing, that is commented out.
    matthijskooijman committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    17482ce View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Configuration menu
    Copy the full SHA
    9735e00 View commit details
    Browse the repository at this point in the history