New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a crash when trying to access a `SpriteComponent`'s `.sprite()` #47

Merged

STREGA merged 1 commit into STREGAsGate:Release-0.2 from mgrider:0.2.1-fixes

Aug 5, 2024

mgrider commented Jul 11, 2024

The intent here is just to make sure there are elements in the animation array before trying to access them.

I considered changing this to a guard, which is how I would write it, but I opted for the smallest change.

Notably, I did also have to change my RenderingSystem subclass to check that the returned sprite's texture isReady before using it.


          make sure there are elements in the animation array before trying to …

8615b06

…access them.

STREGA merged commit a3b520b into STREGAsGate:Release-0.2

3 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet