SUL23-346 Show all published libguides grouped by their type #119
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| {headingLevel === 3 && <h3 className="type-1">Course Guides</h3>} | ||
| <LibGuideSection heading="Course Guides" guides={courseGuides}/> | ||
| {[...groupedGuides.keys()].map(guideTopic => ( | ||
| <div key={guideTopic}> |
There was a problem hiding this comment.
Good catch. I just added space-y-40 to the parent via the node page component. See: https://github.com/SU-SWS/sulgryphon-nextjs/pull/119/files#diff-559377094eac85f2f0ebd97e64e9d47039be55d4ca58213b9db50a79c8347adeR67
Basically it's the same, but doesn't add bottom margin to the last group.
There was a problem hiding this comment.
Yeah, I thought about that, but I noticed on my local that for some reason the last mb-40 isn't applied. It defaults to the mb-50 parent div. But this is good info.
There was a problem hiding this comment.
ahh yeah, it basically results in the same outcome either way.
There was a problem hiding this comment.
I suspect the space-y-40 is safer. But I didn't see anything the tailwind docs that confirm that.
There was a problem hiding this comment.
Yeah, I thought about that, but I noticed on my local that for some reason the last mb-40 isn't applied. It defaults to the mb-50 parent div. But this is good info.
Might be margin collapse. Now I'm off to figure out when I got subscribed to all the changes in this repo. 😆
There was a problem hiding this comment.
🤣 Yeah that must be it. Only the best people are subscribed to this repo 😄
There was a problem hiding this comment.
LOL!
Well, appreciate your insight anyways, Eric.
There was a problem hiding this comment.
I love margin collapse. I feel it's underutilized and is the main difference between margin and padding. Now I'll see myself out 🚶♂️
There was a problem hiding this comment.
I guess this thread is going to more people. lol! That's cool. I mean, I'm actually glad because I learn something today.
READY FOR REVIEW
Summary