Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUL23-450: Adding space in card #134

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented May 13, 2024

READY FOR REVIEW

Summary

Review By (Date)

  • 5/17

Urgency

  • High

Steps to Test

  1. Open the PR
  2. Use Chrome. Make sure you have the Wave plugin added.
  3. Got to the /libraries-0/branches-and-centers on your local or Vercel build.
  4. Open Wave plugin. You will get a panel on the left side of the screen. Go to to the order tab. Look at item 18 to start.
  5. Verify in the Wave that the words have a space in the tool but not visible in the UI.
branches-centers-page

7. What it looked like before.
Screenshot 2024-05-14 at 12 23 22 PM

  1. Library header card: https://su-library-git-sul23-450-missing-space-stanford-libraries.vercel.app/libraries/academy-hall-redwood-city-campus

11. Where the error is on production

prod-example

13. Two examples of it fixed. One with a library name and one without a name.

Screenshot 2024-05-14 at 12 27 02 PM Screenshot 2024-05-14 at 12 25 49 PM

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SUL23-450

See Also

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview May 14, 2024 7:14pm

@jenbreese jenbreese requested a review from imonroe May 14, 2024 19:32
@jenbreese jenbreese changed the base branch from 1.x to release-1.2.0 May 17, 2024 17:34
Copy link
Contributor

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@jenbreese jenbreese merged commit a29c045 into release-1.2.0 May 20, 2024
4 checks passed
@jenbreese jenbreese deleted the SUL23-450--missing-space branch May 20, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants