New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUL23-467: Changed line height on News and Event cards #138

Merged

jenbreese merged 1 commit into release-1.2.0 from SUL23-467--line-height

May 23, 2024

Contributor

jenbreese commented May 21, 2024 •

edited

Loading

READY FOR REVIEW

Summary

Changed line height on headings for the News and Events cards.

Review By (Date)

5/22

Urgency

Normal

Steps to Test

Open the Vercel site.
Look at the cards for News and Event on the homepage: https://su-library-git-sul23-467-line-height-stanford-libraries.vercel.app/
Verify the heading/title is 1.4 and not 1.2.
The cards are all over the site and can be seen on the Library individual pages too.

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

See Also

PR Checklist


          SUL23-467: Changed line height on News and Event cards

25de733

vercel bot commented May 21, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
su-library	✅ Ready (Inspect)	Visit Preview	May 21, 2024 6:39pm

github-actions bot added the size/xs label

vercel bot deployed to Preview

May 21, 2024 18:39

View deployment

jenbreese requested a review from imonroe

May 21, 2024 18:42

jenbreese assigned imonroe

imonroe approved these changes

View reviewed changes

Contributor

imonroe left a comment

Seems simple enough. LGTM.

jenbreese merged commit a4df0d4 into release-1.2.0

4 checks passed

jenbreese deleted the SUL23-467--line-height branch

May 23, 2024 15:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels