SUL23-489: Places to study table.

[jenbreese]

READY FOR REVIEW

Summary

• This is a table view of the Places to Study.
• It has filtering at the top.

Review By (Date)

• 6/24

Criticality

• High

Urgency

• High

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Rebuild Cache and import config drush cr ; drush ci
3. Navigate to a Basic page and add a list of Places to Study. Select the Places to Study Table view.
4. Verify it looks like the design in all the responsive views. There is a small, med and large layout.
5. Verify the filters are working as expected.

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SUL23-442

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
su-library	✅ Ready (Inspect)	Visit Preview	Jun 25, 2024 7:38pm

[jenbreese]

@pookmish I'd like to put a class on this Open but we can't have html in the variable and string them together like the olden days. What is a better way to think about this challenge?

[pookmish]

put the variable into the markup:
<span className="foobar">{openUntil}</span><span> More Stuff</span>

[pookmish]

You should always use the tags and markup in the component, not in variables.

[pookmish]

I want to get some a11y eyes on the hover/checked/focus state of the radio buttons. but we can do that next.