Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUL23-690 | build out and configure accordion component #251

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Dec 11, 2024

READY FOR REVIEW

Summary

  • SUL23-690 | build out and configure accordion component

Review By (Date)

  • When possible

Review Tasks

Setup tasks and/or behavior to test

  1. Navigate to https://su-library-git-feature-sul23-690-stanford-libraries.vercel.app/faq-example
  2. Verify that the accordion appears similarly to the Cardinal NextJS accordion https://cardinal-sites-next.vercel.app/build/paragraphs/faq-accordion-list#be7ddc54-fc1e-4bd2-af03-b46b98f2e6da
  3. Review code

Associated Issues and/or People

  • SUL23-690

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview Jan 7, 2025 7:34pm

Copy link
Contributor

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine, even though there's a pile of deletions from some of the generated files. I'm good with it.

@imonroe imonroe merged commit 0217c29 into 1.x Jan 7, 2025
5 checks passed
@imonroe imonroe deleted the feature/SUL23-690 branch January 7, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants