Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUL23-698 | fixup about us menu item display #253

Merged
merged 2 commits into from
Jan 7, 2025
Merged

SUL23-698 | fixup about us menu item display #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d71c4d4
SUL23-698 | fixup about us menu item display
rebeccahongsf Dec 17, 2024
3ef3ecc
Merge branch '1.x' into bug/SUL23-698--nav
imonroe Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/menu/fallback-main-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const MenuItem = ({url, title}: MenuItemType) => {
href={linkUrl}
className="flex w-full items-center p-20 text-white no-underline hover:bg-black hover:text-white hover:underline focus:bg-black focus:text-white lg:text-black-true lg:hover:bg-transparent lg:hover:text-black-true lg:focus:bg-transparent lg:focus:text-black-true lg:focus:underline"
>
<div className="pl-30 lg:pl-0">{title}</div>
<div className="shrink-0 pl-30 lg:pl-0">{title}</div>
</Link>
</li>
)
Expand Down
4 changes: 2 additions & 2 deletions src/components/menu/main-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ const MenuItem = ({
)}
aria-current={activeTrail.at(-1) === id ? "page" : undefined}
>
<div className={twMerge("pl-30 lg:pl-0", titleSpacing[menuLevel])}>{title}</div>
<div className={twMerge("shrink-0 pl-30 lg:pl-0", titleSpacing[menuLevel])}>{title}</div>
</Link>
)}

Expand All @@ -218,7 +218,7 @@ const MenuItem = ({
onClick={toggleSubmenu}
aria-expanded={submenuOpen ? "true" : "false"}
>
<span className={twMerge("pl-30 lg:pl-0", titleSpacing[menuLevel])}>{title}</span>
<span className={twMerge("shrink-0 pl-30 lg:pl-0", titleSpacing[menuLevel])}>{title}</span>
</button>
)}

Expand Down
Loading