Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUL23-693 | fix html validation issue for social share #254

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Dec 18, 2024

READY FOR REVIEW

Summary

  • SUL23-693 | fix html validation issue for social share

Review By (Date)

  • When possible

Review Tasks

Setup tasks and/or behavior to test

  1. Navigate to a news page
  2. Plug the URL into HTML validator
  3. Verify that the a tag error no longer appears
  4. Review code

Associated Issues and/or People

  • SUL23-693

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview Dec 18, 2024 6:27pm

Copy link
Contributor

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@imonroe imonroe merged commit 88b684e into 1.x Jan 7, 2025
5 checks passed
@imonroe imonroe deleted the byg/SUL23-693--htmlValidation branch January 7, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants