Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoJira: On demand revalidation only and no caching requests. #91

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

sherakama
Copy link
Member

READY FOR REVIEW

Summary

  • Turn off time based revalidation so that only on-demand revalidation happens
  • Opt out of fetch and other library caches

Review By (Date)

  • When you can

Urgency

  • ?

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview Nov 21, 2023 10:03pm

@sherakama
Copy link
Member Author

Since on-demand revalidation is set up opt out of time-based revalidation and any cached fetch calls so that content is cached forever if it doesn't change and fetched new if it does.

Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it and see what happens

@pookmish pookmish merged commit cd2c708 into 1.x Nov 21, 2023
1 of 2 checks passed
@pookmish pookmish deleted the debug branch November 21, 2023 22:20
@sherakama
Copy link
Member Author

For retro, what happened was we set the pages to SSR on each request with no caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants