Refactor codebase and fix TS issues #94
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pookmish
force-pushed
the
refactor-prefix
branch
from
8570974 to
a524ff3
Compare
|
Deployment failed with the following error: Learn More: https://vercel.link/invalid-route-destination-segment |
pookmish
force-pushed
the
refactor-prefix
branch
from
a524ff3 to
57ef9bf
Compare
pookmish
force-pushed
the
refactor-prefix
branch
from
57ef9bf to
3f67810
Compare
pookmish
force-pushed
the
refactor-prefix
branch
from
3f67810 to
75f52ac
Compare
pookmish
force-pushed
the
refactor-prefix
branch
from
75f52ac to
b51d713
Compare
pookmish
force-pushed
the
refactor-prefix
branch
from
b51d713 to
bcc64ce
Compare
| // Opt out of caching for all data requests in the route segment | ||
| export const dynamic = 'force-dynamic'; | ||
| export const revalidate = 0; | ||
| export const revalidate = 2592000; |
There was a problem hiding this comment.
Can you tell me more about why you chose 30 days? Why not cache forever?
There was a problem hiding this comment.
🤷 Just a number i chose.
There was a problem hiding this comment.
I figured we had it at 1 day before, this is more cache. If we have no issues with this, we can increase it to infinite
There was a problem hiding this comment.
Are you using this route? If not, perhaps delete it as it caused me some confusion when I first stumbled upon it.
There was a problem hiding this comment.
I kept it in case it eventually works.
There was a problem hiding this comment.
and also to test it out to find out if it works.
| @@ -32,14 +33,16 @@ export const metadata = { | |||
| } | |||
| } | |||
|
|
|||
| export const revalidate = 86400; | |||
There was a problem hiding this comment.
Can you tell me more about this revalidation time? Why only one day here but 30 on the page route? Wouldn't you want the layout to be cached longer than the slots?
There was a problem hiding this comment.
This allows the menu to revalidate more frequent since the page invalidation doesn't invalidate that.
| }, | ||
| ] | ||
| }; | ||
| ignoreBuildErrors: process.env.CI !== 'true', |
There was a problem hiding this comment.
What build errors are causing you issues?
There was a problem hiding this comment.
here it actually doesn't have an issue. but if we ever do a yarn install --prod in vercel, it will cause build errors. This keeps the build errors in Github Actions
| "axios": "^1.1.3", | ||
| "critters": "^0.0.20", | ||
| "decanter": "^7.0.0-rc.2", | ||
| "drupal-jsonapi-params": "^2.0.0", | ||
| "html-react-parser": "^5.0.6", | ||
| "jsona": "^1.11.0", | ||
| "next": "^14.0.1", | ||
| "next": "^13.0", |
There was a problem hiding this comment.
What is not working in Next 14 that you had to roll back?
There was a problem hiding this comment.
The route interception kept throwing errors. I debugged it for a few hours and then this seemed to fix it. Not sure exactly why that solved the issue
READY FOR REVIEW/NOT READY
Summary
Review By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People
@mentionthem here)See Also