Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/molecule/stepper): improve compressed style UX #2695

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

jordevo
Copy link
Contributor

@jordevo jordevo commented Feb 6, 2024

molecule/stepper

🔍 Show

Making step label's text flow through the component:
image

Also fixing for vertical disposition:
image

TASK:

Description, Motivation and Context

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles
  • 🛠️ Tool

Screenshots - Animations

Copy link

github-actions bot commented Feb 6, 2024

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0.03↑ ≍ 0= ≍ 0=
% 76.17 63.58 65.72 77.94
ABS 3335 / 4378 1968 / 3095 648 / 986 3163 / 4058

Copy link

github-actions bot commented Feb 6, 2024

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0.03↑ ≍ 0= ≍ 0=
% 76.17 63.58 65.72 77.94
ABS 3335 / 4378 1968 / 3095 648 / 986 3163 / 4058

Copy link
Member

@andresin87 andresin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work in vertical mode?

@jordevo
Copy link
Contributor Author

jordevo commented Feb 6, 2024

@andresin87 @giodelabarrera thanks for reviewing the PR... turns out the issue with the label when the component had the design='COMPRESSED' set came from the way the demo is generating the labels...

https://github.com/SUI-Components/sui-components/blob/master/components/molecule/stepper/demo/articles/ArticleDesignAlignment.js#L26-L28

so nothing to worry about that... will remove those changes

Copy link

github-actions bot commented Feb 6, 2024

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0= ≍ 0= ≍ 0=
% 76.17 63.5 65.72 77.93
ABS 3334 / 4377 1973 / 3107 648 / 986 3161 / 4056

Copy link

github-actions bot commented Feb 6, 2024

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0= ≍ 0= ≍ 0=
% 76.17 63.5 65.72 77.93
ABS 3334 / 4377 1973 / 3107 648 / 986 3161 / 4056

@jordevo
Copy link
Contributor Author

jordevo commented Feb 6, 2024

Does it work in vertical mode?

it works now! :)

image

Copy link

github-actions bot commented Feb 6, 2024

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0.01↑ ≍ 0= ≍ 0=
% 76.17 63.51 65.72 77.93
ABS 3334 / 4377 1976 / 3111 648 / 986 3161 / 4056

@jordevo jordevo merged commit 1675f9d into master Feb 6, 2024
7 checks passed
@jordevo jordevo deleted the feat-molecule-stepper-compressed-improve-ux branch February 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants