Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components/atom/checkbox): modify wrapper element syntax #2809

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat(components/atom/checkbox): modify wrapper element syntax #2809

merged 1 commit into from
Jan 20, 2025

Conversation

andresin87
Copy link
Member

atom/checkbox

🔍 Show

TASK:

Description, Motivation and Context

modify checkbox wrapper for a11y purposes from unintended label to span

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles
  • 🛠️ Tool

Screenshots - Animations

@andresin87 andresin87 added this to the a11y milestone Jan 20, 2025
@github-actions GitHub Actions
Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0＝ ≍ 0＝ ≍ 0＝ ≍ 0＝
% 75.87 64.06 65.6 77.65
ABS 3378 / 4452 2073 / 3236 658 / 1003 3197 / 4117

@andresin87 andresin87 merged commit 0c978be into master Jan 20, 2025
7 checks passed
@andresin87 andresin87 deleted the a11y-checkbox-label-wrapper branch January 20, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sui-bot sui-bot Awaiting requested review from sui-bot sui-bot is a code owner

@kikoruiz kikoruiz Awaiting requested review from kikoruiz kikoruiz is a code owner

@andresz1 andresz1 Awaiting requested review from andresz1 andresz1 is a code owner

Assignees

@andresin87 andresin87

Labels
a11y atom checkbox
Projects
None yet
Milestone
a11y
Development

Successfully merging this pull request may close these issues.
1 participant
@andresin87