Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/atom/icon): icon a11y #2830

Merged
merged 3 commits into from
Feb 7, 2025
Merged

feat(components/atom/icon): icon a11y #2830

merged 3 commits into from
Feb 7, 2025

Conversation

andresin87
Copy link
Member

@andresin87 andresin87 commented Feb 6, 2025

atom/icon

🚢 Ship

TASK:

  • Open classNames
    • Mod tests
  • Open prop spreading to be able to track data and aria attributes
    • Add tests
  • Add section to understand how to deal with a11y for icons usage in brand marketplace projects.

Description, Motivation and Context

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles
  • 🛠️ Tool

Screenshots - Animations

Copy link

github-actions bot commented Feb 6, 2025

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0= ≍ 0= ≍ 0=
% 75.96 64.07 65.73 77.74
ABS 3394 / 4468 2078 / 3243 662 / 1007 3213 / 4133

@Elisabetmh
Copy link

Use label prop so it could be announced correctly by screen readers. There is no visual difference.

Most icons or icon systems come with no accessibility built-in. For example, the same visual cross icon may in fact mean "close" or "delete". This component lets you give meaning to icons used throughout your app.

@andresin87 andresin87 merged commit ea56abc into master Feb 7, 2025
7 checks passed
@andresin87 andresin87 deleted the icon-a11y branch February 7, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants