Don't use public hostname to resolve certificate file locations #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the test instance both the public and private hostname should be `docker-test.platform.sunet.se`. For the production instance they should be `docker.platform.sunet.se`, and when it goes live `registry_public_hostname` should be changed to `docker.sunet.se` The corresponding variable in docker_registry.pp is called "fqdn"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the test instance both the public and private hostname should be
docker-test.platform.sunet.se.For the production instance they should be
docker.platform.sunet.se, and when it goes liveregistry_public_hostnameshould be changed todocker.sunet.seThe corresponding variable in docker_registry.pp is called "fqdn"