Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh entity list on delete/restore #205

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

TeodoraPavlova
Copy link
Contributor

How to reproduce - go to entity list page and delete/restore entity. The list does not get refreshed (without manual page reload).

@crazyscientist crazyscientist self-assigned this Apr 19, 2024
@crazyscientist
Copy link
Collaborator

Hi there, I just checked the reproduction steps and come to a little different conclusion:

So, I selected 4 entities for deletion and the app sent 4 DELETE requests and 1 GET request in order to update the list:

grafik

In my particular case, the updated list kept showing one of the deleted entities. So, I would conclude, that there is a race condition and that the app is not waiting for the completion of all DELETE requests prior to the GET request.

frontend/src/components/EntityList.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityList.vue Outdated Show resolved Hide resolved
TeodoraPavlova and others added 2 commits April 19, 2024 11:52
Co-authored-by: Andreas Hasenkopf <[email protected]>
Co-authored-by: Andreas Hasenkopf <[email protected]>
@crazyscientist crazyscientist merged commit c123bdd into master Apr 19, 2024
4 checks passed
@crazyscientist crazyscientist deleted the fix-entity-list-refresh-on-delete-restore branch April 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants