-
Notifications
You must be signed in to change notification settings - Fork 29
Get rid of the caasp_cmd.run state (bsc#1127036) #754
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, looks good
f3d0d9c
to
ff27951
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, i will look at CI failures, and see if it is a flakyness thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change, it looks great
@mjura can you look at the |
failed : http://jenkins.caasp.suse.net/blue/organizations/jenkins/salt.integration/detail/PR-754/3/ rerunning to see if we fail always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc5934a
to
409987f
Compare
@jordimassaguerpla this time the Pipeline failed on Note the flakyness are in Product not in CI. The |
1 run passed, retriggering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
2nd run was ok too. let's retrigger 3 times in a row |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
409987f
to
dc111db
Compare
ff27951
to
2e8d89e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we can check if CI is green. it could be failing on update
but is not due to this pr.
of the standard Salt cmd.run state (and it was messing with it). bsc#1127036 Signed-off-by: Alvaro Saurin <[email protected]>
2e8d89e
to
b2a3289
Compare
caasp_cmd.run
state, as theretry
is now part of the standard Saltcmd.run
state (and it was messing with it).bsc#1127036
This SHOULD be ported to 3.0.