Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Get rid of the caasp_cmd.run state (bsc#1127036) #754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inercia
Copy link
Contributor

@inercia inercia commented Feb 28, 2019

  • Get rid of the caasp_cmd.run state, as the retry is now part of the standard Salt cmd.run state (and it was messing with it).

bsc#1127036

This SHOULD be ported to 3.0.

MalloZup
MalloZup previously approved these changes Feb 28, 2019
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good

@inercia inercia force-pushed the wait_for_successful_query_interval branch from f3d0d9c to ff27951 Compare February 28, 2019 17:27
@spiarh spiarh changed the title Get rid of the caasp_cmd.run state Get rid of the caasp_cmd.run state (bsc#1127036) Mar 1, 2019
MalloZup
MalloZup previously approved these changes Mar 1, 2019
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i will look at CI failures, and see if it is a flakyness thing

mjura
mjura previously approved these changes Mar 1, 2019
Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change, it looks great

@MalloZup
Copy link
Contributor

MalloZup commented Mar 1, 2019

@mjura can you look at the orch.update failure?

@MalloZup
Copy link
Contributor

MalloZup commented Mar 1, 2019

failed : http://jenkins.caasp.suse.net/blue/organizations/jenkins/salt.integration/detail/PR-754/3/

rerunning to see if we fail always

@MalloZup MalloZup dismissed stale reviews from mjura and themself via 0eef1b3 March 1, 2019 14:47
@MalloZup MalloZup requested review from mjura and MalloZup March 1, 2019 15:06
MalloZup
MalloZup previously approved these changes Mar 1, 2019
mjura
mjura previously approved these changes Mar 1, 2019
Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MalloZup MalloZup dismissed stale reviews from mjura and themself via cc5934a March 1, 2019 16:47
@MalloZup MalloZup force-pushed the wait_for_successful_query_interval branch from cc5934a to 409987f Compare March 1, 2019 16:49
@MalloZup
Copy link
Contributor

MalloZup commented Mar 1, 2019

@jordimassaguerpla this time the Pipeline failed on boostrap orch 📛 we will need to wait next week to investiage more the other race condition. i will retrigger to see if it pass after failure :(

Note the flakyness are in Product not in CI. The boostrap error might need to be investigated. (http://jenkins.caasp.suse.net/job/salt.integration/job/PR-754/7/artifact/logs/salt-events-summary.txt)

@MalloZup
Copy link
Contributor

MalloZup commented Mar 4, 2019

1 run passed, retriggering

mjura
mjura previously approved these changes Mar 4, 2019
Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MalloZup
Copy link
Contributor

MalloZup commented Mar 4, 2019

2nd run was ok too. let's retrigger 3 times in a row

bergmannf
bergmannf previously approved these changes Mar 4, 2019
Copy link
Contributor

@bergmannf bergmannf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MalloZup MalloZup dismissed stale reviews from bergmannf and mjura via dc111db March 4, 2019 14:45
@MalloZup MalloZup force-pushed the wait_for_successful_query_interval branch from 409987f to dc111db Compare March 4, 2019 14:45
@MalloZup MalloZup changed the title Get rid of the caasp_cmd.run state (bsc#1127036) ON_HOLD: Get rid of the caasp_cmd.run state (bsc#1127036) Mar 4, 2019
@MalloZup MalloZup changed the title ON_HOLD: Get rid of the caasp_cmd.run state (bsc#1127036) [WIP]: Get rid of the caasp_cmd.run state (bsc#1127036) Mar 4, 2019
@inercia inercia force-pushed the wait_for_successful_query_interval branch 2 times, most recently from ff27951 to 2e8d89e Compare March 6, 2019 10:04
@inercia inercia changed the title [WIP]: Get rid of the caasp_cmd.run state (bsc#1127036) Get rid of the caasp_cmd.run state (bsc#1127036) Mar 6, 2019
@inercia inercia requested review from MalloZup, mjura and bergmannf and removed request for mjura March 6, 2019 10:06
MalloZup
MalloZup previously approved these changes Mar 6, 2019
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can check if CI is green. it could be failing on update but is not due to this pr.

@MalloZup MalloZup removed the on hold label Mar 6, 2019
of the standard Salt cmd.run state (and it was messing with it).

bsc#1127036

Signed-off-by: Alvaro Saurin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants