Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS subnet split fixes #311

Merged
merged 2 commits into from
Jan 23, 2025
Merged

AWS subnet split fixes #311

merged 2 commits into from
Jan 23, 2025

Conversation

mpagot
Copy link
Collaborator

@mpagot mpagot commented Jan 22, 2025

This PR does not change anything in qe-sap two typical use-cases:

  • 1 HANA node for mr_test
  • 2 HANA nodes for HanaSR

But is supposed to allow going beyond 2 hana nodes, and more in general reduce the code complexity, makes the code more similar to the Azure one, change variable validation from regexp to a dedicated CIDR validation function.

Verification

HanaSR

sle-15-SP6-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_6_BYOS-qesap_aws_fencing_native_test

 + resource "aws_subnet" "infra-subnet" {
      + cidr_block                                     = "10.0.0.0/24"

...

  # module.hana_node.aws_instance.hana[0] will be created
  + resource "aws_instance" "hana" {
      + private_ip                           = "10.0.1.10"

...

  # module.hana_node.aws_instance.hana[1] will be created
  + resource "aws_instance" "hana" {
      + private_ip                           = "10.0.2.11"

...

  # module.hana_node.aws_subnet.hana-subnet[0] will be created
  + resource "aws_subnet" "hana-subnet" {
      + cidr_block                                     = "10.0.1.0/24"
...

  # module.hana_node.aws_subnet.hana-subnet[1] will be created
  + resource "aws_subnet" "hana-subnet" {
      + cidr_block                                     = "10.0.2.0/24"

Job failure is later for timeout in crm resource refresh msl_SAPHanaCtl_HQ0_HDB00

mr_test

sle-12-SP5-EC2-SAP-BYOS-Incidents-saptune-x86_64-Build:36967:kernel-ec2-sles4sap_gnome_saptune_delete_rename@ec2_r5b.metal -> http://openqaworker15.qa.suse.cz/tests/311636

Remove variables that are not used in terraform. All of them are about
configurations now managed by Ansible, like registration and SID.
Copy link
Collaborator

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@BillAnastasiadis BillAnastasiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpagot mpagot merged commit 40757c6 into SUSE:main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants