2nd PR. Add SVF's byte size and fix some api use #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. add MaxByteLimit Option
2) add isStaticDeterminedByteSize and getByteSizeOfObj in ObjTypeInfo (with getter/setter) and MemObj(only getter) 3) fulfill SymbolTableBuilder::initTypeInfo() to init the ByteSize related field
2) fix a bug in IntervalValue compare Op 3) remove ConstantOffset bool flag. Instead, if byteSize != 0, it is signal of constant offset. If byteSize = 0, it can be zero byte size or non-const offset. 4) add analyzeHeapAllocByteSize(const Value*), which accepts a CallInst like (malloc/calloc/..) and analyze the allocation byte Size of heap function 5) remove the hard code (99999) of maxByteLimit in SVFIR2ItvExeState::getBytefromGepTypePair, and replace it with Options::MaxFieldLimit()
2) add getByteSize and SetByteSize in SVFType
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
==========================================
- Coverage 64.50% 64.49% -0.02%
==========================================
Files 223 223
Lines 23767 23766 -1
==========================================
- Hits 15331 15327 -4
- Misses 8436 8439 +3
|
yuleisui
reviewed
Nov 28, 2023
| @@ -74,7 +74,7 @@ class SVFIR2ItvExeState | |||
| VAddrs getGepObjAddress(u32_t pointer, APOffset offset); | |||
|
|
|||
| /// Return the byte offset from one gep param offset | |||
| std::pair<APOffset, APOffset> getBytefromGepTypePair(const AccessPath::VarAndGepTypePair& gep_pair, const GepStmt *gep); | |||
| IntervalValue getBytefromGepTypePair(const AccessPath::VarAndGepTypePair& gep_pair, const GepStmt *gep); | |||
|
|
|||
| /// Return the Index offset from one gep param offset | |||
| std::pair<APOffset, APOffset> getIndexfromGepTypePair(const AccessPath::VarAndGepTypePair& gep_pair, const GepStmt *gep); | |||
There was a problem hiding this comment.
getItvOfFlattenedElemIndex
| @@ -74,7 +74,7 @@ class SVFIR2ItvExeState | |||
| VAddrs getGepObjAddress(u32_t pointer, APOffset offset); | |||
|
|
|||
| /// Return the byte offset from one gep param offset | |||
| std::pair<APOffset, APOffset> getBytefromGepTypePair(const AccessPath::VarAndGepTypePair& gep_pair, const GepStmt *gep); | |||
| IntervalValue getBytefromGepTypePair(const AccessPath::VarAndGepTypePair& gep_pair, const GepStmt *gep); | |||
| @@ -84,7 +84,7 @@ class SVFIR2ItvExeState | |||
| /// e.g. GepStmt* gep = [i32*10], x, and x is [0,3] | |||
| /// std::pair<s32_t, s32_t> byteOffset = getGepByteOffset(gep); | |||
| /// byteOffset should be [0, 12] since i32 is 4 bytes. | |||
| std::pair<APOffset, APOffset> getGepByteOffset(const GepStmt *gep); | |||
| IntervalValue getGepByteOffset(const GepStmt *gep); | |||
|
|
|||
| /// Return the offset expression of a GepStmt | |||
| std::pair<APOffset, APOffset> getGepOffset(const GepStmt *gep); | |||
There was a problem hiding this comment.
getItvOfFlattenedElemIndex
| @@ -74,7 +74,7 @@ class SVFIR2ItvExeState | |||
| VAddrs getGepObjAddress(u32_t pointer, APOffset offset); | |||
|
|
|||
| /// Return the byte offset from one gep param offset | |||
| std::pair<APOffset, APOffset> getBytefromGepTypePair(const AccessPath::VarAndGepTypePair& gep_pair, const GepStmt *gep); | |||
| IntervalValue getBytefromGepTypePair(const AccessPath::VarAndGepTypePair& gep_pair, const GepStmt *gep); | |||
There was a problem hiding this comment.
VarAndGepTypePair => IdxVarAndGepTypePair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.