Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add argvalvar #1626

Merged
merged 3 commits into from
Jan 10, 2025
Merged

add argvalvar #1626

merged 3 commits into from
Jan 10, 2025

Conversation

jumormt
Copy link
Contributor

@jumormt jumormt commented Jan 9, 2025

No description provided.

@jumormt
Copy link
Contributor Author

jumormt commented Jan 9, 2025

--- log/nginx.log 2025-01-10 09:25:58.395637165 +1100
+++ log/nginx-xiao.log 2025-01-10 09:25:53.163692474 +1100
@@ -39,9 +39,9 @@
VarArrayObj 153
VarStructObj 630
----------------Time and memory stats--------------------
-LLVMIRTime 1.642
-SVFIRTime 1.025
-SymbolTableTime 0.181
+LLVMIRTime 1.644
+SVFIRTime 1.04
+SymbolTableTime 0.18
#######################################################

PTACallGraph Stats (Andersen analysis)******
@@ -68,11 +68,11 @@
CollapseTime 0
CopyGepTime 0
LoadStoreTime 0
-MemoryUsageVmrss 2.32214e+06
-MemoryUsageVmsize 2.32224e+06
+MemoryUsageVmrss 2.32234e+06
+MemoryUsageVmsize 2.32223e+06
SCCDetectTime 0
SCCMergeTime 0
-TotalTime 121.015
+TotalTime 123.166
UpdateCGTime 0
----------------Numbers stats----------------------------
AddrProcessed 5909
@@ -144,11 +144,11 @@
CollapseTime 0
CopyGepTime 0
LoadStoreTime 0
-MemoryUsageVmrss 2.3269e+06
-MemoryUsageVmsize 2.327e+06
+MemoryUsageVmrss 2.32734e+06
+MemoryUsageVmsize 2.32699e+06
SCCDetectTime 0
SCCMergeTime 0
-TotalTime 134.901
+TotalTime 137.314
UpdateCGTime 0
----------------Numbers stats----------------------------
AddrProcessed 5909
@@ -210,9 +210,9 @@
LookupComplements 336293
PreemptiveComplements 6541
TotalIntersections 1796736
-PropertyIntersections 1783019
+PropertyIntersections 1783105
UniqueIntersections 34
-LookupIntersections 580
+LookupIntersections 494
PreemptiveIntersections 13103
#######################################################

@@ -220,11 +220,11 @@
################ (program : nginx.bc)###############
----------------Time and memory stats--------------------
AverageRegSize 39.1348
-GenMUCHITime 1.241
-GenRegionTime 84.385
-InsertPHITime 0.431
-SSARenameTime 0.025
-TotalMSSATime 86.086
+GenMUCHITime 1.12
+GenRegionTime 86.428
+InsertPHITime 0.38
+SSARenameTime 0.029
+TotalMSSATime 87.958
----------------Numbers stats----------------------------
BBHasMSSAPhi 4056
CSChiNode 22213
@@ -247,13 +247,13 @@
SVFG Statistics******
################ (program : nginx.bc)###############
----------------Time and memory stats--------------------
-ATNodeTime 0.203
+ATNodeTime 0.214
AvgWeight 198.378
ConnDirEdgeTime 0
-ConnIndEdgeTime 1.315
+ConnIndEdgeTime 1.319
OptTime 0
TLNodeTime 0
-TotalTime 1.518
+TotalTime 1.533
----------------Numbers stats----------------------------
ActualIn 30142
ActualOut 22213
@@ -315,20 +315,20 @@
GepTime 0
IndirectPropaTime 0
LoadTime 0
-MemoryUsageVmrss 4.78237e+06
-MemoryUsageVmsize 4.83125e+06
+MemoryUsageVmrss 4.78451e+06
+MemoryUsageVmsize 4.83468e+06
PhiTime 0
-PrelabelingTime 0.165
+PrelabelingTime 0.163
ProcessTime 0
PropagationTime 0
SCCTime 0
-SolveTime 815.774
+SolveTime 824.373
StoreTime 0
Strong/WeakUpdTime 0
-TotalTime 890.22
+TotalTime 897.326
UpdateCGTime 0
VersionPropTime 0
-meldLabelingTime 71.739
+meldLabelingTime 70.305
----------------Numbers stats----------------------------
CopysNum 80
DummyFieldPtrs 1510
@@ -348,11 +348,11 @@
ProcessedAddr 23636
ProcessedCopy 320
ProcessedFRet 0
-ProcessedGep 885162
-ProcessedLoad 1171445
+ProcessedGep 889238
+ProcessedLoad 1173671
ProcessedMSSANode 344692
-ProcessedPhi 74937
-ProcessedStore 632521
+ProcessedPhi 75137
+ProcessedStore 636652
SolveIterations 4
StoresNum 14929
StrongUpdates 282
@@ -367,12 +367,12 @@

Persistent Points-To Cache Statistics: flow-sensitive analysis bitvector
################ (program : nginx.bc)###############
-UniquePointsToSets 33801
-TotalUnions 1930574908
-PropertyUnions 1231644376
-UniqueUnions 123230
-LookupUnions 698649182
-PreemptiveUnions 158120
+UniquePointsToSets 33875
+TotalUnions 1946066385
+PropertyUnions 1231203257
+UniqueUnions 123752
+LookupUnions 714580687
+PreemptiveUnions 158689
TotalComplements 0
PropertyComplements 0
UniqueComplements 0

@@ -578,6 +578,13 @@ class SVFIR : public IRGraph
return addValNode(nullptr, node, i);
}

NodeID addArgValNode(const CallGraphNode* callGraphNode, u32_t argNo,
bool isUncalled, NodeID i, const ICFGNode* icfgNode) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put bool isUncalled as the last parameter and a default parameter to be false.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.92%. Comparing base (4e366d1) to head (510abb1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
svf/include/SVFIR/SVFVariables.h 20.00% 4 Missing ⚠️
svf/lib/Util/ThreadAPI.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1626      +/-   ##
==========================================
+ Coverage   62.89%   62.92%   +0.02%     
==========================================
  Files         247      247              
  Lines       27715    27747      +32     
  Branches     4547     4550       +3     
==========================================
+ Hits        17432    17460      +28     
- Misses      10283    10287       +4     
Files with missing lines Coverage Δ
svf-llvm/lib/SVFIRBuilder.cpp 84.07% <100.00%> (+0.17%) ⬆️
svf/include/Graphs/GenericGraph.h 81.44% <ø> (ø)
svf/include/SVFIR/SVFIR.h 92.42% <100.00%> (+0.11%) ⬆️
svf/include/Util/SVFUtil.h 85.41% <ø> (-0.59%) ⬇️
svf/lib/SVFIR/SVFFileSystem.cpp 35.57% <100.00%> (+0.04%) ⬆️
svf/lib/SVFIR/SVFIR.cpp 77.27% <100.00%> (+0.07%) ⬆️
svf/lib/SVFIR/SVFVariables.cpp 49.36% <100.00%> (+4.20%) ⬆️
svf/lib/Util/SVFUtil.cpp 45.51% <100.00%> (+1.43%) ⬆️
svf/lib/Util/ThreadAPI.cpp 21.05% <0.00%> (ø)
svf/include/SVFIR/SVFVariables.h 64.78% <20.00%> (-2.12%) ⬇️

... and 3 files with indirect coverage changes

@yuleisui yuleisui merged commit ce18a46 into SVF-tools:master Jan 10, 2025
5 checks passed
@jumormt jumormt deleted the 1.9 branch January 10, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants