[마이페이지] style qa를 위한 변경 사항 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 21, 2024 17:40
hoeun0723
added
fix 🛠️
|
imeureka
approved these changes
Feb 23, 2024
| @@ -18,7 +18,7 @@ export const TextWrapper = styled.div` | |||
|
|
|||
| export const Text = styled.div` | |||
| ${({ theme: { fonts } }) => fonts.heading_01}; | |||
| > p { | |||
| > span { | |||
There was a problem hiding this comment.
혹시 span태그로 바꾸신 이유가 뭔지 알 수 있을까요?? 지난 번 합숙 때 기본 p태그는 모바일에선 파란색인 것이라고 호은님께 배웠었는데, 혹시 그때문인지... 만약 이 이유로 바꾸신 것이라면 저도 바꿔야해서요!!
There was a problem hiding this comment.
흠 그 부분을 상기시켜 한것은 아닙니다!
p태그는 기본적으로 엔터를 동반한 태그이기 때문에, 한 문장안에서 부분적으로 스타일 적용을 하기 위해선 p태그가 아닌 span를 활용해야겠다고 생각했기 때문입니다!
Comment on lines
21
to
24
| // 컴포넌트가 언마운트될 때 이벤트 리스너 제거 | ||
| return () => { | ||
| window.removeEventListener('scroll', handleScroll); | ||
| }; |
There was a problem hiding this comment.
오 이벤트리스너를 원래 제거까지 해줘야하는 것이었군요??
또 하나 배워갑니다 :)
ExceptAnyone
approved these changes
Feb 23, 2024
urjimyu
approved these changes
Feb 23, 2024
| @@ -10,11 +10,18 @@ interface DoneCardRoomType { | |||
| } | |||
|
|
|||
| const DoneCardRoom = ({ user, srcImage, userCount, onClick }: DoneCardRoomType) => { | |||
| const multiline = user.length > 3 || (/[a-zA-Z]/.test(user) && user.length > 5); | |||
| // 스크롤 이벤트 핸들러 | ||
| const handleScroll = () => { | ||
| const scrollTop = window.pageYOffset || document.documentElement.scrollTop; | ||
| setIsTop(scrollTop === 0); // 스크롤이 맨 위에 있는지 여부를 상태에 설정 |
There was a problem hiding this comment.
스크롤에 따라 헤더 변경 너무 좋네요! 디자인 의도에 맞게 표현하기 위한 고민하신 흔적이 보입니다 최고최고✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
📸 스크린샷
figma 와 동일하게 적용 !! header도 밑으로 내릴때만 색상 적용되게 수정
bandicam.2024-02-23.02-47-19-729.mp4
[화면 안 움직이게]
bandicam.2024-02-23.02-47-42-206.mp4
Reference