-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[선물방 메인] 삭제 모달 공통 컴포넌트로 분리, 플로팅 버튼 기능 추가 #445
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다!! 조건 활용과 옵서녈 처리를 하니 공통으로 사용할 수 있은 컴포넌트가 되었네요!! merge 해주시면 사용해보고, 문제 있으면 또 말씀 드리거나 직접 수정하겠습니다!! 감사합니다😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다! 고생하셨어요 :)
const handleClickConfirmDeleteBtn = (giftId?: number) => { | ||
if (giftId !== undefined) { | ||
mutation.mutate(giftId); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if 문으로 mutation을 넣었군요! 저도 이렇게 모달을 열어보겠습니다!
이슈 넘버
구현 사항
Need Review
플로팅 버튼 조건 추가
react-toastify
를 조건에 따라 다른 커스텀 위치에 뜨도록 하고 싶은 분들은 해당 PR 참고하시면 좋을 것 같아요!공통 DeleteModal 사용법
모달을 여닫기 위한 setState를 넘겨주는 것으로 수정했습니다! (다른 방식 제안도 환영입니다)
모달 컴포넌트
📸 스크린샷
Screen.Recording.2024-02-29.at.8.35.02.PM.mov
Reference