[온보딩] 사파리에서 날짜 형식 NaN, undefined 뜨는 현상 수정 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
urjimyu
approved these changes
Feb 29, 2024
| @@ -39,8 +39,8 @@ const OnboardingFinal = (props: OnboardingFinalProps) => { | |||
| new Date(onboardingInfo.tournamentStartDate), | |||
| DURATION_MAPPING[onboardingInfo.tournamentDuration as keyof typeof DURATION_MAPPING] as number, | |||
| ); | |||
| const formattedEndDate = format(tournamentEndDate, 'yyyy-MM-dd'); | |||
There was a problem hiding this comment.
이 부분이 브라우저 이슈 때문에 생긴 수정 사항이군요!
There was a problem hiding this comment.
맞아여 ㅠ PR 내용 조금 더 자세하게 수정하고 관련 링크 첨부했는데 한 번 확인해보셔도 좋을 것 같습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
작업하기 편하게 하기 위해서, 이미 머지된 다른 브랜치에서의 작업내용을 복붙해서 진행했어요! 그래서 file changed가 5로 되어 있는데, 사실상 Step06와 ParticipantView만 봐주셔도 될거같습니다!
이 부분에서도 날짜 형식에 원래 ' . ' 을 사용하던 것을 ' - '로 바꿔주니 사파리에서 바로 인식되더라구요!
관련 링크 첨부합니다!!
https://velog.io/@pjhyng0125/js-Date-object-생성-시-IOS-safari-스크립트-오류-발생-특정-날짜의-요일-정보-반환-함수
📸 스크린샷
Reference