[온보딩] step02 -> step03 넘어갈 때 스켈레톤 ui 적용 #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imeureka
approved these changes
Mar 11, 2024
hoeun0723
approved these changes
Mar 11, 2024
urjimyu
approved these changes
Mar 11, 2024
Comment on lines
40
to
52
| const OnboardingSkeletonWrapper = styled.div` | ||
| gap: 11.6rem; | ||
| `; | ||
|
|
||
| const TitleWrapper = styled.div` | ||
| ${({ theme }) => theme.mixin.flexBox({ direction: 'column' })}; | ||
| gap: 0.9rem; | ||
| border-radius: 4px; | ||
| `; | ||
|
|
||
| const DetailWrapper = styled.div` | ||
| margin-top: 11.6rem; | ||
| `; |
There was a problem hiding this comment.
요 부분 스타일 파일 분리해도 될 것 같아요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
스켈레톤이라는 컴포넌트를 따로 만들고 isLoading 상태 boolean값에 따라 보여지게 만들었습니다.
suspense는 왜인지 모르겠는데 적용이 안되더라구요 ㅠ
시간 촉박 이슈로 일단 isLoading으로 처리했습니다.
추후 리팩토링 때 suspense 더 공부하고 적용시키겠습니다!
아래 영상은 로딩중 스켈레톤 ui를 보기 위해 일부러 아주 고용량 이미지 업로드를 진행한 점 참고부탁드립니다!
📸 스크린샷
2024-03-11.10.06.03.mov
Reference