[토너먼트] 토너먼트 라운딩 카드 제작 완료 #59
Merged
+155
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+24
to
+25
| border: ${({ isClicked }) => | ||
| isClicked ? '3px solid var(--Pink-P-06, #FF2176)' : '3px solid var(--Gray-G-02, #ebe9ea)'}; |
imeureka
commented
Jan 10, 2024
| position: relative; | ||
| border-radius: 12px; | ||
| border: ${({ isClicked }) => | ||
| isClicked ? '3px solid var(--Pink-P-06, #FF2176)' : '3px solid var(--Gray-G-02, #ebe9ea)'}; |
|
|
||
| export const Title = styled.p` | ||
| height: 4.2rem; | ||
| word-break: keep-all; |
There was a problem hiding this comment.
오 이거 찾아보니 단어의 분리를 어떻게 할 것인지 결정하는 것이군요!! 새롭게 알아갑니다
ExceptAnyone
approved these changes
Jan 10, 2024
hoeun0723
approved these changes
Jan 10, 2024
Comment on lines
+29
to
+32
| <S.Price>{formatPrice(8130000)}원</S.Price> | ||
| {/* 보러가기 컴포넌트 분리할까 말까 링크있는 | ||
| 아이템이면 생성 조건 렌더링 */} | ||
| </S.ItemInfo> |
There was a problem hiding this comment.
ㅎㅎ 흠.. 이 부분을 보고 figma 를 한번 보고 왔는데요, 해당 페이지가 아닌 다른 페이지에서도 반복적으로 쓰이는 재사용가능한 친구이기 때문에 컴포넌트로 분리 하는게 좋지 않을까 생각했어요 !!
urjimyu
approved these changes
Jan 10, 2024
| position: relative; | ||
| border-radius: 12px; | ||
| border: ${({ isClicked }) => | ||
| isClicked ? '3px solid var(--Pink-P-06, #FF2176)' : '3px solid var(--Gray-G-02, #ebe9ea)'}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
📸 스크린샷
2024-01-09.10.02.30.mov
Reference