[온보딩페이지] Step01 기본적 기능 구현 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
또한 인풋창을 감싸고 있는 div에 속성을 주어 값이 입력되었을 때 빨간색 밑줄 처리 하였습니다
hoeun0723
approved these changes
Jan 10, 2024
| `; | ||
|
|
||
| export const Input = styled.input<{ hasContent?: boolean; maxLengthReached?: boolean }>` | ||
| ${({ theme }) => theme.mixin.flexBox('flex-center', 'center')}; |
There was a problem hiding this comment.
mixin 관련 부분 저번 pr 과 같이 확인을 한번 해보면 좋을 거 같아요 !!
계속 이렇게 쓰이는걸 보면, 잘 적용 되는거 같긴한데, 아마 이렇게 넘겨지는 값들에 key값을 적어주지 않게 되면 순서대로 적용이 될텐데, 추후 확장성을 위한 코드가 되진 않을 거 같다고 판단했어요
추가적으로 flex-center라는 코드를 한번 더 보면, 그냥 center를 의미하려던게 아닌가 생각했습니다 !확인 부탁드려요 !
There was a problem hiding this comment.
아 이 부분 전에 올린 PR에서 전부 수정 후 푸쉬하였습니다 !!
urjimyu
approved these changes
Jan 10, 2024
imeureka
approved these changes
Jan 10, 2024
imeureka
approved these changes
Jan 10, 2024
| hasContent={text.length > 0} | ||
| maxLengthReached={text.length === 10} | ||
| /> | ||
| <S.Wrapper hasContent={text.length > 0} maxLengthReached={text.length === 10}> |
There was a problem hiding this comment.
wrapper는 명확하게 무엇을 감싸고 있는지 네이밍 해주면 더 가독성 좋은 코드가 될 것 같아요 이부분은 이제 NameInputWrapper 가 될 수 있을 것 같아요!
There was a problem hiding this comment.
좀 전 PR에서 리마인드 완전 감사합니다!! 아까 PR에서 컨벤션 맞추는 커밋 진행하였습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
step01에 기본적인 기능 구현하였습니다
ex) x 아이콘 클릭 시 인풋창 전체 값 삭제, 글자를 입력했을 시에만 보이게 설정 등
📸 스크린샷
Reference