-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flutter music player UI #5
Conversation
Hi @Kavindu-Gayantha, The UI Looks Cool. I request to do the following changes to merge the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Requested
Ok , I will make changes. |
@Safnaj All done.
|
android:label="music_app" | ||
android:label="Music_App" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also change the Main Project name as Music_App
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add ur mockup in the main readme file here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. got it
Hi @Kavindu-Gayantha, I have added hactoberfest-accepted label for you. In order to merge ur PR, pls change the project name as first capital letter. Check the below image. |
previously i changed name in android manifest file also. I thought it solved. now changed in the packages. as Music_App |
@Kavindu-Gayantha i was telling to change this not the manifest file. As ler the unpublished code of conduct we follow a proper naming convention. Therefore it has to be a capital letter |
I thought it might have solved like that, I renamed now again. |
related toi issue #1 .