Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter music player UI #5

Merged
merged 15 commits into from
Oct 23, 2020
Merged

flutter music player UI #5

merged 15 commits into from
Oct 23, 2020

Conversation

Kavindu-Gayantha
Copy link
Contributor

related toi issue #1 .

@Safnaj
Copy link
Owner

Safnaj commented Oct 21, 2020

Hi @Kavindu-Gayantha, The UI Looks Cool.

I request to do the following changes to merge the PR.

  • Change music_app to First Letter Capital as Music_App
  • The UI in readme file looks very big
  • Also update a Mockup same as in the Main ReadMe file

Copy link
Owner

@Safnaj Safnaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Requested

@Kavindu-Gayantha
Copy link
Contributor Author

Hi @Kavindu-Gayantha, The UI Looks Cool.

I request to do the following changes to merge the PR.

* [ ]  Change music_app to First Letter Capital as Music_App

* [ ]  The UI in readme file looks very big

* [ ]  Also update a Mockup same as in the Main ReadMe file

Ok , I will make changes.

@Kavindu-Gayantha
Copy link
Contributor Author

@Safnaj All done.

  • Change music_app to First Letter Capital as Music_App

  • The UI in readme file looks very big

  • Also update a Mockup same as in the Main ReadMe file

android:label="music_app"
android:label="Music_App"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change the Main Project name as Music_App

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add ur mockup in the main readme file here

ReadMe Link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. got it

@Safnaj Safnaj added the hacktoberfest-accepted Hacktoberfest PR Accepted label Oct 22, 2020
@Safnaj
Copy link
Owner

Safnaj commented Oct 22, 2020

Hi @Kavindu-Gayantha, I have added hactoberfest-accepted label for you. In order to merge ur PR, pls change the project name as first capital letter. Check the below image.

Screenshot 2020-10-23 at 12 43 17 AM

@Kavindu-Gayantha
Copy link
Contributor Author

Hi @Kavindu-Gayantha, I have added hactoberfest-accepted label for you. In order to merge ur PR, pls change the project name as first capital letter. Check the below image.

Screenshot 2020-10-23 at 12 43 17 AM

previously i changed name in android manifest file also. I thought it solved. now changed in the packages. as Music_App

@Safnaj
Copy link
Owner

Safnaj commented Oct 23, 2020

@Kavindu-Gayantha i was telling to change this not the manifest file. As ler the unpublished code of conduct we follow a proper naming convention. Therefore it has to be a capital letter

@Kavindu-Gayantha
Copy link
Contributor Author

@Kavindu-Gayantha i was telling to change this not the manifest file. As ler the unpublished code of conduct we follow a proper naming convention. Therefore it has to be a capital letter

I thought it might have solved like that, I renamed now again.

@Safnaj Safnaj merged commit cad5db1 into Safnaj:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest PR Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants