-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #32 from Sage-Bionetworks-Workflows/bwmac/orca-293…
…/airflow-constraints CI testing
- Loading branch information
Showing
6 changed files
with
45 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,3 +60,7 @@ MANIFEST | |
|
||
# Metaflow files | ||
.metaflow | ||
|
||
# Virtual Environment Directories | ||
/venv | ||
/py-orca-venv-* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# Contributing | ||
|
||
Welcome to `orca` contributor's guide. | ||
Welcome to `py-orca` contributor's guide. | ||
|
||
This document focuses on getting any potential contributor familiarized with | ||
the development processes, but [other kinds of contributions] are also appreciated. | ||
|
@@ -16,7 +16,7 @@ behavior guidelines. | |
|
||
## Issue Reports | ||
|
||
If you experience bugs or general issues with `orca`, please have a look | ||
If you experience bugs or general issues with `py-orca`, please have a look | ||
on the [issue tracker]. | ||
If you don't see anything useful there, please feel free to fire an issue report. | ||
|
||
|
@@ -34,17 +34,17 @@ you help us to identify the root cause of the issue. | |
|
||
## Documentation Improvements | ||
|
||
You can help improve `orca` docs by making them more readable and coherent, or | ||
You can help improve py-`orca` docs by making them more readable and coherent, or | ||
by adding missing information and correcting mistakes. | ||
|
||
`orca` documentation uses [Sphinx] as its main documentation compiler. | ||
`py-orca` documentation uses [Sphinx] as its main documentation compiler. | ||
This means that the docs are kept in the same repository as the project code, and | ||
that any documentation update is done in the same way was a code contribution. | ||
The documentation is written using [CommonMark] with [MyST] extensions. | ||
|
||
:::{tip} | ||
Please notice that the [GitHub web interface] provides a quick way of | ||
propose changes in `orca`'s files. While this mechanism can | ||
propose changes in `py-orca`'s files. While this mechanism can | ||
be tricky for normal code contributions, it works perfectly fine for | ||
contributing to the docs, and can be quite handy. | ||
|
||
|
@@ -87,7 +87,7 @@ Before you work on any non-trivial code contribution it's best to first create | |
a report in the [issue tracker] to start a discussion on the subject. | ||
This often provides additional considerations and avoids unnecessary work. | ||
|
||
### Clone the repository | ||
### Development Environment Setup | ||
|
||
1. Create an user account on GitHub if you do not already have one. | ||
|
||
|
@@ -98,22 +98,25 @@ This often provides additional considerations and avoids unnecessary work. | |
|
||
```console | ||
git clone [email protected]:Sage-Bionetworks-Workflows/py-orca.git | ||
cd orca | ||
cd py-orca | ||
``` | ||
|
||
4. Install `pipx` to easily run Python CLI tools like `tox` and `pipenv`. | ||
|
||
4. Create an isolated virtual environment containing package dependencies, | ||
including those needed for development (*e.g.* testing, documentation) by running: | ||
|
||
```console | ||
pipx run tox -e pipenv | ||
./dev_setup.sh <your_supported_python_version> | ||
source py-orca-venv-<your_supported_python_version>/bin/activate | ||
``` | ||
|
||
**Note:** | ||
Ensure that you have a supported Python version installed on your local machine before running `dev_setup.sh`. `py-orca` currently supports Python version 3.10 and 3.11. You can [install](https://github.com/pyenv/pyenv?tab=readme-ov-file#installation) `pyenv`for easy Python version management. | ||
|
||
|
||
5. Install [pre-commit] hooks: | ||
|
||
``` | ||
pipenv run pre-commit install | ||
pre-commit install | ||
``` | ||
|
||
`orca` comes with a lot of hooks configured to automatically help the | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
#!/bin/bash | ||
|
||
# Usage: ./dev_setup.sh <python_version> | ||
|
||
# Check if Python version argument is provided | ||
if [ -z "$1" ]; then | ||
echo "Please provide the Python version as an argument." | ||
exit 1 | ||
fi | ||
# Check if Python version is supported | ||
if [ "$1" != "3.10" ] && [ "$1" != "3.11" ]; then | ||
echo "Unsupported Python version. Please use 3.10 or 3.11." | ||
exit 1 | ||
fi | ||
# Set up and activate a Python 3.11 virtual environment | ||
python$1 -m venv py-orca-venv-$1 | ||
source py-orca-venv-$1/bin/activate | ||
# Upgrade pip to latest version | ||
pip install --upgrade pip | ||
# Install airflow with constraints | ||
pip install -r requirements-airflow.txt | ||
# Install py-orca | ||
pip install -e '.[all,testing,dev]' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
-c https://raw.githubusercontent.com/apache/airflow/constraints-2.7.2/constraints-3.10.txt | ||
apache-airflow==2.7.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters